You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mesos.apache.org by al...@apache.org on 2018/03/29 11:15:13 UTC
mesos git commit: Revert "Fixed disconnection for
ATTACH_CONTAINER_INPUT call...".
Repository: mesos
Updated Branches:
refs/heads/master af2a404b5 -> 5984cb725
Revert "Fixed disconnection for ATTACH_CONTAINER_INPUT call...".
This reverts commit 02ebf9986ab5ce883a71df72e9e3392a3e37e40e.
Though this patch does fix the intended issue, it apparently surfaces
a bug in libprocess, which leads to a deadlock during IOSwitchBoard
finalization. Until the libprocess bug is fixed, it is better to
drop a single message and have one flaky tests than have a process
stuck during the cleanup and have multiple flaky tests and likely
issues in production.
Project: http://git-wip-us.apache.org/repos/asf/mesos/repo
Commit: http://git-wip-us.apache.org/repos/asf/mesos/commit/5984cb72
Tree: http://git-wip-us.apache.org/repos/asf/mesos/tree/5984cb72
Diff: http://git-wip-us.apache.org/repos/asf/mesos/diff/5984cb72
Branch: refs/heads/master
Commit: 5984cb72589415402f769190b124e172f72cfb39
Parents: af2a404
Author: Alexander Rukletsov <al...@apache.org>
Authored: Thu Mar 29 13:10:35 2018 +0200
Committer: Alexander Rukletsov <al...@apache.org>
Committed: Thu Mar 29 13:11:11 2018 +0200
----------------------------------------------------------------------
src/slave/containerizer/mesos/io/switchboard_main.cpp | 7 -------
1 file changed, 7 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/mesos/blob/5984cb72/src/slave/containerizer/mesos/io/switchboard_main.cpp
----------------------------------------------------------------------
diff --git a/src/slave/containerizer/mesos/io/switchboard_main.cpp b/src/slave/containerizer/mesos/io/switchboard_main.cpp
index c6ea214..7e8e844 100644
--- a/src/slave/containerizer/mesos/io/switchboard_main.cpp
+++ b/src/slave/containerizer/mesos/io/switchboard_main.cpp
@@ -116,8 +116,6 @@ int main(int argc, char** argv)
<< " '" + stringify(strsignal(SIGTERM)) << "'";
}
- process::initialize();
-
Try<Owned<IOSwitchboardServer>> server = IOSwitchboardServer::create(
flags.tty,
flags.stdin_to_fd.get(),
@@ -153,11 +151,6 @@ int main(int argc, char** argv)
server->reset();
- // NOTE: We need to finalize libprocess, on Windows especially,
- // as any binary that uses the networking stack on Windows must
- // also clean up the networking stack before exiting.
- process::finalize(true);
-
if (!run.isReady()) {
EXIT(EXIT_FAILURE) << "The io switchboard server failed: "
<< (run.isFailed() ? run.failure() : "discarded");