You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by PaulAngus <gi...@git.apache.org> on 2016/08/19 15:57:41 UTC
[GitHub] cloudstack pull request #1652: Marvin Tests: Fix VPC network offering select...
GitHub user PaulAngus opened a pull request:
https://github.com/apache/cloudstack/pull/1652
Marvin Tests: Fix VPC network offering selection .
It appears that original code did not expect there to be an alternate default VPC offering (Nuage) .
VPC selection uses isdefault=True which selects the Nuage Network offering, stopping the test from being run.
Fix was to look for name="Default VPC Offering" instead.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shapeblue/cloudstack vpcselectionfix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1652.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1652
----
commit f1b64a3b509ed59ac0061a4e11dbff34d7ce1ba0
Author: Paul Angus <pa...@shapeblue.com>
Date: 2016-08-19T15:29:22Z
VPC fix network offering.
orginal code did not expect there to be an alternate default (Nuage) there when the isdefault=True is used a Nuage Network offering is returned stopping the test from being run.
Fix was to look for name="Default VPC Offering"
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus is their PR superceded by #1688?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network
offering selection .
Posted by Sergey Levitskiy <Se...@autodesk.com>.
@koushik-das Actually there are 3 default VPC offerings.
Default VPC offering
Redundant VPC offering
Nuage VSP VPC Offering
The last 2 were introduced in May. VPC offering becomes default if 4th parameter is true in createVpcOffering e.g.
createVpcOffering(nuageVPCOfferingName, nuageVPCOfferingDisplayText, NUAGE_VSP_VPC_SERVICE_MAP, true, VpcOffering.State.Enabled, null);
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1652
There should be only one default VPC offering, unless I am missing out something obvious :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus following up on PR feedback. @fmaximus did you apply this patch in another PR? If so, could you please provide a reference?
If this patch has not been addressed elsewhere, I would like to get this fix into the upcoming 4.9.10 and 4.10.0.0 releases for which RCs will be cut on 25 Sept 2016. Assuming this issue is also present in 4.9, could you please re-target the PR and investigate the Jenkins failure.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by fmaximus <gi...@git.apache.org>.
Github user fmaximus commented on the issue:
https://github.com/apache/cloudstack/pull/1652
I will make the change. I also plan to only create the vpc offering if there are Nuage VSP devices configured, which makes more sense for the users of CloudStack that do not use our plugin.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the issue:
https://github.com/apache/cloudstack/pull/1652
Thanks frank, would you make that change to the Nuage Network offering or shall I?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1652
LGTM, the Travis test failures are not related to this PR but with tearDown issues fixed here: https://github.com/apache/cloudstack/pull/1648
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1652: Marvin Tests: Fix VPC network offering select...
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus closed the pull request at:
https://github.com/apache/cloudstack/pull/1652
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by fmaximus <gi...@git.apache.org>.
Github user fmaximus commented on the issue:
https://github.com/apache/cloudstack/pull/1652
As Nuage plugin developer, I can't come up with any good reason why it should be default.
Also I see that Redundant VPC Offering is set to be a default.
Both are most likely just copied from defaultVPCOfferingName creation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by PaulAngus <gi...@git.apache.org>.
Github user PaulAngus commented on the issue:
https://github.com/apache/cloudstack/pull/1652
Without full understanding of the Nuage plugin, fixing the test seemed the safest path, one hopes that the nuage offering was configured that way for a good reason.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus Shouldn't the product code be fixed instead of the test? If the isDefault property on VPC offerings in not working then that needs to be fixed. I checked the vpc_offerings table in the DB and there is a 'default' field.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1652: Marvin Tests: Fix VPC network offering selection .
Posted by jburwell <gi...@git.apache.org>.
Github user jburwell commented on the issue:
https://github.com/apache/cloudstack/pull/1652
@PaulAngus does this defect occur in 4.9 as well? If so, please re-target the PR to the 4.9 branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---