You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "zhipeng93 (via GitHub)" <gi...@apache.org> on 2023/03/31 09:31:15 UTC

[GitHub] [flink-ml] zhipeng93 commented on pull request #221: [FLINK-31189] Add HasMaxIndexNum param to StringIndexer

zhipeng93 commented on PR #221:
URL: https://github.com/apache/flink-ml/pull/221#issuecomment-1491627983

   > Thanks for the PR. LGTM overall.
   > 
   > My only concern is that the term `bucket` is not explicitly introduced before introducing the parameter. `Bucket` appears to be an uncommon term in the context of `StringIndexer`.
   > 
   > To enhance clarity, perhaps we could include a brief description to introduce the concept of `bucket`, or consider renaming it with a more commonly used term, like `index`?
   
   Thanks for the review. I have update the param name to `maxIndexNum`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org