You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Vasu Nori (JIRA)" <ji...@apache.org> on 2008/05/06 02:39:56 UTC

[jira] Created: (SHINDIG-233) Default format for RESTful API should be json-c.

Default format for RESTful API should be json-c. 
-------------------------------------------------

                 Key: SHINDIG-233
                 URL: https://issues.apache.org/jira/browse/SHINDIG-233
             Project: Shindig
          Issue Type: Bug
          Components: RESTful API (Java)
            Reporter: Vasu Nori


The current implementation of RESTful API is returning Atom/XML no matter what the "format" specifier is. 
Two issues:
1. Accept format specifier in query string with acceptable values being "atom", "json-c"
2. If the format specifier is missing, default to "json-c"


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-233) Default format for RESTful API should be json-c.

Posted by "David Primmer (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594431#action_12594431 ] 

David Primmer commented on SHINDIG-233:
---------------------------------------

I'm in support of this change, as it follows the spec. However, see my recent comment on what the spec says about "json" versus "json-c" question here: http://groups.google.com/group/opensocial-and-gadgets-spec/browse_thread/thread/ed71e411040958b4

In addition to switching to the default, what it's called should be resolved in the spec soon.


> Default format for RESTful API should be json-c. 
> -------------------------------------------------
>
>                 Key: SHINDIG-233
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-233
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (Java)
>            Reporter: Vasu Nori
>         Attachments: patch_addformat_n_paramsbug
>
>
> The current implementation of RESTful API is returning Atom/XML no matter what the "format" specifier is. 
> Two issues:
> 1. Accept format specifier in query string with acceptable values being "atom", "json-c"
> 2. If the format specifier is missing, default to "json-c"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SHINDIG-233) Default format for RESTful API should be json-c.

Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Cassie Doll resolved SHINDIG-233.
---------------------------------

    Resolution: Fixed
      Assignee: Cassie Doll

> Default format for RESTful API should be json-c. 
> -------------------------------------------------
>
>                 Key: SHINDIG-233
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-233
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (Java)
>            Reporter: Vasu Nori
>            Assignee: Cassie Doll
>         Attachments: patch_addformat_n_paramsbug
>
>
> The current implementation of RESTful API is returning Atom/XML no matter what the "format" specifier is. 
> Two issues:
> 1. Accept format specifier in query string with acceptable values being "atom", "json-c"
> 2. If the format specifier is missing, default to "json-c"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (SHINDIG-233) Default format for RESTful API should be json-c.

Posted by "Cassie Doll (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SHINDIG-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12594598#action_12594598 ] 

Cassie Doll commented on SHINDIG-233:
-------------------------------------

Okay, we can change the format name if the spec changes it, that shouldn't be a problem. 

Vasu - I made a small change to your patch. I changed the way you retrieved the "format" param from the url to be the same way  you retrieve the other params (uid, pid etc) from the url by using getParameter instead of getParameterNames. This eliminates several lines of code. 

> Default format for RESTful API should be json-c. 
> -------------------------------------------------
>
>                 Key: SHINDIG-233
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-233
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (Java)
>            Reporter: Vasu Nori
>         Attachments: patch_addformat_n_paramsbug
>
>
> The current implementation of RESTful API is returning Atom/XML no matter what the "format" specifier is. 
> Two issues:
> 1. Accept format specifier in query string with acceptable values being "atom", "json-c"
> 2. If the format specifier is missing, default to "json-c"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SHINDIG-233) Default format for RESTful API should be json-c.

Posted by "Vasu Nori (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SHINDIG-233?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vasu Nori updated SHINDIG-233:
------------------------------

    Attachment: patch_addformat_n_paramsbug

Attached patch file to address this issue

After this patch is in, the URLs can have format in query string

for example: 
  URL before this patch
         http://localhost:8080/social/rest/activities/jane.doe/@self
     returned Atom/XML

  URL after this patch
       http://localhost:8080/social/rest/activities/jane.doe/@self
       or   http://localhost:8080/social/rest/activities/jane.doe/@self?format=json-c
    will return JSON-c

     http://localhost:8080/social/rest/activities/jane.doe/@self?format=atom
   will return Atom/XML

NOTE that this patch is just a small step towards JSON-c work. not the final patch at all..


> Default format for RESTful API should be json-c. 
> -------------------------------------------------
>
>                 Key: SHINDIG-233
>                 URL: https://issues.apache.org/jira/browse/SHINDIG-233
>             Project: Shindig
>          Issue Type: Bug
>          Components: RESTful API (Java)
>            Reporter: Vasu Nori
>         Attachments: patch_addformat_n_paramsbug
>
>
> The current implementation of RESTful API is returning Atom/XML no matter what the "format" specifier is. 
> Two issues:
> 1. Accept format specifier in query string with acceptable values being "atom", "json-c"
> 2. If the format specifier is missing, default to "json-c"

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.