You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "sfirke (via GitHub)" <gi...@apache.org> on 2023/02/08 15:58:51 UTC
[GitHub] [superset] sfirke opened a new issue, #23034: No warning when deleting a dataset used in dashboard native filters
sfirke opened a new issue, #23034:
URL: https://github.com/apache/superset/issues/23034
It's helpful that Superset will tell you when you go to delete a dataset, "this is used in 2 charts that appear in 3 dashboards." But it doesn't report on usage in dashboard _filters_. When replacing one dataset with another, the native filter usage needs to be replaced, too, and Superset should alert if deleting the dataset will break filters.
#### How to reproduce the bug
1. Create a dashboard and use a dataset column in a filter
2. Delete the dataset
3. View the dashboard. It will have a red box "Cannot load filter"
### Expected results
When I try to delete the dataset, the statement about usage should include "and is used in X filters on Y dashboards."
Also, if the user deletes the dataset when it's used in filters, that field should become blank in the filter so that they can select a replacement field.
### Actual results
No warnings about usage in filters. And when you try to replace the source table for those filters, instead of the dropdown there's an infinitely-spinning Superset logo.
#### Screenshots
### Environment
Superset 2.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] No warning when deleting a dataset used in dashboard native filters [superset]
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #23034:
URL: https://github.com/apache/superset/issues/23034#issuecomment-1947460320
I can try to reproduce it. It was an annoying bug, I deleted a dataset and inadvertently broke a dashboard.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] sfirke commented on issue #23034: No warning when deleting a dataset used in dashboard native filters
Posted by "sfirke (via GitHub)" <gi...@apache.org>.
sfirke commented on issue #23034:
URL: https://github.com/apache/superset/issues/23034#issuecomment-1426349444
Related: the user should be warned if a report they try to delete is used in a scheduled report or alert (#23059).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] No warning when deleting a dataset used in dashboard native filters [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #23034:
URL: https://github.com/apache/superset/issues/23034#issuecomment-1947456341
tempted to close this as stale, but let me know your thoughts @sfirke :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org