[GitHub] [doris] Mryange commented on a diff in pull request #20863: [fix](datetime) Fix the error in date calculation that includes constants

["Mryange (via GitHub)" <gi...@apache.org>]

Mryange commented on code in PR #20863:
URL: https://github.com/apache/doris/pull/20863#discussion_r1233461748


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/types/DateTimeV2Type.java:
##########
@@ -78,6 +78,17 @@ public static DateTimeV2Type forType(DataType dataType) {
         return MAX;
     }
 
+    /**
+     * return proper type of datetimev2 for VarcharLiteral
+     * may be we need to check for validity?
+     */
+    public static DateTimeV2Type forTypeFromVarcharLiteral(String s) {

Review Comment:
   It has already been determined StringLikeLiteral, so it is unnecessary to check again.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org