[GitHub] [incubator-iotdb] jixuan1989 commented on issue #445: generate cpp, go, and python thrift files under service-rpc

[GitBox <gi...@apache.org>]

jixuan1989 commented on issue #445: generate cpp, go, and python thrift files under service-rpc
URL: https://github.com/apache/incubator-iotdb/pull/445#issuecomment-541988772
 
 
   > This is fine.
   > But programmers of other languages do not usually have maven installed, so I doubt whether this is that useful.
   > And I would appreciate it if you add a parameter like `mvn generate-sources py` to let the user select what they want to build instead of building all at once.
   
   Actually, for users who do not install maven, they can use `./mvnw.sh generate-sources` ... 
   allowing claiming which language codes users want is good, but I think it is ok now because generating codes is very fast..
   
   What interests me is that  @chrisdutz  said "this is just generating codes, rather compile them as a module"... 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services