[GitHub] [nifi] simonbence commented on a change in pull request #4195: NIFI-7292 Preventing file listing from fail because of insufficient privileges

[GitBox <gi...@apache.org>]

simonbence commented on a change in pull request #4195: NIFI-7292 Preventing file listing from fail because of insufficient privileges
URL: https://github.com/apache/nifi/pull/4195#discussion_r408229468
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/ListFile.java
 ##########
 @@ -547,31 +549,67 @@ public boolean test(final Path path, final BasicFileAttributes attributes) {
             }
         };
 
-        final Stream<Path> inputStream = getPathStream(basePath, maxDepth, matcher);
+        try {
+            final long start = System.currentTimeMillis();
 
 Review comment:
   You are perfectly right with that there is a difference in the way my solution proposal was implemented. I tried to highlight this on the description but I did miss to directly notify the reporter of the ticket indeed. Now I asked for his approval so the future of the PR is highly depend on his answer.
   
   As for the test I think the two mechanism in this implementation works somewhat independent but in order to properly cover the possibilities I added a case should cover the possible interference.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services