You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "mdedetrich (via GitHub)" <gi...@apache.org> on 2024/03/18 09:49:38 UTC
[I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [incubator-pekko]
mdedetrich opened a new issue, #1205:
URL: https://github.com/apache/incubator-pekko/issues/1205
In https://github.com/apache/incubator-pekko/pull/252 I made it so that we can set `SupervisionStrategy` rather than using `SubStreamCancelStrategy`. It turns out there is an existing test which was written as pending (so its currently disabled) to test this exact `SupervisionStrategy` functionality (specifically `SupervisionStrategy.resumingDecider` when an exception is thrown) i.e.
https://github.com/apache/incubator-pekko/blob/c44c0b7cbdab11d85176cfe062288fdcba16c56a/stream-tests/src/test/scala/org/apache/pekko/stream/scaladsl/FlowSplitAfterSpec.scala#L213-L262
When I try to enable the test by removing `pending` it actually does not pass which means that the `SupervisionStrategy.resumingDecider` is not properly catching and suppressing the exception as its meant to do so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich commented on issue #1205:
URL: https://github.com/apache/incubator-pekko/issues/1205#issuecomment-2003376801
So I set the 1.1.0-M1 milestone for this bug, will do my best to solve it by the time the release is actually cut however if its not done by then can do it in a following `-M2` or full release.
It does however need to be solved by full 1.1.0 release
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [I] SubFlow's don't correctly propagate `Supervision.resumeStrategy` [incubator-pekko]
Posted by "mdedetrich (via GitHub)" <gi...@apache.org>.
mdedetrich closed issue #1205: SubFlow's don't correctly propagate `Supervision.resumeStrategy`
URL: https://github.com/apache/incubator-pekko/issues/1205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org