You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hawq.apache.org by "Caleb Welton (JIRA)" <ji...@apache.org> on 2015/10/12 23:22:05 UTC

[jira] [Commented] (HAWQ-21) cdbpersistentstore.h line 440

    [ https://issues.apache.org/jira/browse/HAWQ-21?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14953759#comment-14953759 ] 

Caleb Welton commented on HAWQ-21:
----------------------------------

Confirmed this looks like a bug.  Without the '\' in the macro the variable writePersistentStateLockLocalVars will be a global variable rather than a local variable.  This /shouldn't/ cause any bugs, but it does reduce the amount that the compiler can provide proper validation.  It would be good to fix.

What's less clear to me is how the persistent table code is applicable in HAWQ since the core logic of the persistent mirroring mechanism has been replaced by HDFS mirroring.



> cdbpersistentstore.h line 440
> -----------------------------
>
>                 Key: HAWQ-21
>                 URL: https://issues.apache.org/jira/browse/HAWQ-21
>             Project: Apache HAWQ
>          Issue Type: Bug
>          Components: Storage
>            Reporter: Feng Tian
>            Assignee: Lei Chang
>
> I believe you missed a \ in the multiline macro.   I maybe wrong.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)