[GitHub] [flink] reswqa commented on a diff in pull request #20293: [FLINK-27904][runtime] Introduce HsMemoryDataManager

[GitBox <gi...@apache.org>]

reswqa commented on code in PR #20293:
URL: https://github.com/apache/flink/pull/20293#discussion_r924307597


##########
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/hybrid/HsMemoryDataSpiller.java:
##########
@@ -60,11 +60,10 @@ public HsMemoryDataSpiller(FileChannel dataFileChannel) {
      *     (subpartitionId, bufferIndex).
      * @return the completable future contains spilled buffers information.
      */
-    public CompletableFuture<List<SpilledBuffer>> spillAsync(
-            List<BufferWithIdentity> bufferToSpill) {
-        CompletableFuture<List<SpilledBuffer>> spilledFuture = new CompletableFuture<>();
-        ioExecutor.execute(() -> spill(bufferToSpill, spilledFuture));
-        return spilledFuture;
+    public void spillAsync(

Review Comment:
   good catch, updated.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org