[GitHub] [lucene-solr] gerlowskija opened a new pull request #1058: SOLR-13972: Warn about insecure settings on startup

[GitBox <gi...@apache.org>]

gerlowskija opened a new pull request #1058: SOLR-13972: Warn about insecure settings on startup
URL: https://github.com/apache/lucene-solr/pull/1058
 
 
   # Description
   Solr should warn users on startup if insecure settings are being used.
   
   # Solution
   Currently I've added the detection and message for this in bin/solr.  I'm not sure this is the best place for this logic - I'd like to keep logic out of bash/powershell where possible, and a smarter check would look at security.json in ZooKeeper, which is easier to do within the JVM.
   
   But this PR is still worth reviewing if anyone has feedback on the language or appearance of the warning.
   
   # Tests
   
   I've done manual testing, but that's it.  If we had a `bin/solr` test framework as SOLR-11749 proposes, we could conceivably write tests for this, but that's a major task and isn't going to happen anytime soon.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org