You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org> on 2019/08/02 11:05:13 UTC
[Impala-ASF-CR] IMPALA-8549: Add support for scanning DEFLATE text files
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/13857 )
Change subject: IMPALA-8549: Add support for scanning DEFLATE text files
......................................................................
Patch Set 6: Code-Review+1
(3 comments)
The code looks good to me. Did you do any interop tests, e.g. create .deflate files with Hive and read them with Impala?
http://gerrit.cloudera.org:8080/#/c/13857/6//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13857/6//COMMIT_MSG@24
PS6, Line 24: as if their compression type is ZLIB.
Maybe it's also worth to mention that deflate is the default compression in Hadoop. Because it's a bit confusing that the default compression is deflate, which has three flavors, and we use the zlib flavor.
http://gerrit.cloudera.org:8080/#/c/13857/6/be/src/exec/hdfs-text-scanner.cc
File be/src/exec/hdfs-text-scanner.cc:
http://gerrit.cloudera.org:8080/#/c/13857/6/be/src/exec/hdfs-text-scanner.cc@95
PS6, Line 95: gzip-, snappy- and bzip2
nit: maybe add deflate to this list
http://gerrit.cloudera.org:8080/#/c/13857/6/be/src/exec/hdfs-text-scanner.cc@204
PS6, Line 204: DEFAULT
nit: Please extend the comment why we use DEFAULT here instead of ZLIB.
--
To view, visit http://gerrit.cloudera.org:8080/13857
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I45e41ab5a12637d396fef0812a09d71fa839b27a
Gerrit-Change-Number: 13857
Gerrit-PatchSet: 6
Gerrit-Owner: Ethan Xue <et...@cloudera.com>
Gerrit-Reviewer: Abhishek Rawat <ar...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Ethan Xue <et...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Sahil Takiar <st...@cloudera.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 02 Aug 2019 11:05:13 +0000
Gerrit-HasComments: Yes