You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by "chengkai15 (via GitHub)" <gi...@apache.org> on 2024/10/14 03:45:40 UTC
[PR] upload bt local bug fix and features [nuttx]
chengkai15 opened a new pull request, #14224:
URL: https://github.com/apache/nuttx/pull/14224
*Note: Please adhere to [Contributing Guidelines](https://github.com/apache/nuttx/blob/master/CONTRIBUTING.md).*
## Summary
*Update this section with information on why change is necessary,
what it exactly does and how, if new feature shows up, provide
references (dependencies, similar problems and solutions), etc.*
## Impact
*Update this section, where applicable, on how change affects users,
build process, hardware, documentation, security, compatibility, etc.*
## Testing
*Update this section with details on how did you verify the change,
what Host was used for build (OS, CPU, compiler, ..), what Target was
used for verification (arch, board:config, ..), etc. Providing build
and runtime logs from before and after change is highly appreciated.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2415933421
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2409911274
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2413459489
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2416418731
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2416630747
```
====================================================================================
Cmake in present: nrf5340-dk/rpmsghci_nimble_cpuapp,CONFIG_ARM_TOOLCHAIN_GNU_EABI
Configuration/Tool: nrf5340-dk/rpmsghci_nimble_cpuapp,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2024-10-16 11:50:39
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Select HOST_LINUX=y
-- Build type:
-- Host: Linux/x86_64
-- Target: NuttX/arm
-- Machine: arm
-- Vendor: none
-- Host: Linux/x86_64
-- Target: NuttX/arm
-- Machine: arm
-- C_FLAGS : -Wall -Wextra
Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Building NuttX...
-- Build type:
-- Host: Linux/x86_64
-- Target: NuttX/arm
-- Machine: arm
-- Vendor: none
-- Host: Linux/x86_64
-- Target: NuttX/arm
-- Machine: arm
-- C_FLAGS : -Wall -Wextra
[1/5] cd /github/workspace/sources/nuttx/build/libs/libc/misc && /usr/local/bin/cmake -E touch /github/workspace/sources/nuttx/libs/libc/misc/lib_utsname.c
[2/5] Linking C executable nuttx
FAILED: nuttx
: && /tools/ccache/bin/arm-none-eabi-gcc --specs=nosys.specs -Wl,--entry=__start -nostdlib -Wl,--gc-sections -Wl,--cref -Wl,-Map=nuttx.map CMakeFiles/nuttx.dir/empty.c.obj -o nuttx -mtune=cortex-m33 -march=armv8-m.main+dsp -mfpu=fpv5-sp-d16 -mfloat-abi=hard -fno-common -Wall -Wshadow -Wundef -nostdlib -Os -fno-strict-aliasing -fomit-frame-pointer -fstack-protector-all -fstack-usage -mthumb -Wa,-mthumb -Wa,-mimplicit-it=always -ffunction-sections -fdata-sections -Wno-attributes -Wno-unknown-pragmas -Wstrict-prototypes -Wno-psabi -T flash_app.ld.tmp -Wl,--start-group openamp/libmetal/lib/libmetal.a openamp/open-amp/lib/libopen_amp.a arch/libarch.a binfmt/libbinfmt.a drivers/libdrivers.a fs/libfs.a libs/libc/libc.a mm/libmm.a net/libnet.a sched/libsched.a wireless/libwireless.a boards/libboard.a apps/libapps.a apps/wireless/bluetooth/nimble/libnimble.a apps/builtin/libapps_builtin.a apps/system/nsh/libapps_nsh.a apps/system/nsh/libapps_sh
.a /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/thumb/v8-m.main+fp/hard/libgcc.a /tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/lib/thumb/v8-m.main+fp/hard/libm.a -Wl,--end-group && :
/tools/gcc-arm-none-eabi/bin/../lib/gcc/arm-none-eabi/13.2.1/../../../../arm-none-eabi/bin/ld: boards/libboard.a(nrf53_bringup.c.obj): in function `nrf53_bringup':
nrf53_bringup.c:(.text.nrf53_bringup+0x68): undefined reference to `bt_driver_register_with_id'
collect2: error: ld returned 1 exit status
ninja: build stopped: subcommand failed.
```
please fix the link error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2416874052
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#discussion_r1803631732
##########
arch/sim/src/sim/sim_hcisocket.c:
##########
@@ -332,35 +305,17 @@ int sim_bthcisock_register(int dev_id)
return -ENOMEM;
}
-#if defined(CONFIG_BLUETOOTH_BRIDGE)
- ret = bt_bridge_register(&dev->drv, &btdrv, &bledrv);
- if (ret < 0)
- {
- goto end;
- }
-
- ret = bthcisock_driver_register(btdrv, dev_id, true);
- if (ret < 0)
- {
- goto end;
- }
-
- ret = bthcisock_driver_register(bledrv, dev_id, false);
- if (ret < 0)
- {
- goto end;
- }
-
-end:
-#else
- ret = bthcisock_driver_register(&dev->drv, dev_id, true);
-#endif
-
+#ifdef CONFIG_DRIVERS_BLUETOOTH
+ ret = bt_driver_register_with_id(&dev->drv, dev_id);
if (ret < 0)
{
+ wlerr("bt_driver_register error: %d\n", ret);
bthcisock_free(dev);
return ret;
}
+#else
+# error "Please select CONFIG_DRIVERS_BLUETOOTH"
Review Comment:
add one space before error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2418395403
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2419173013
this also breaks ALL user configurations that do not set `CONFIG_DRIVERS_BLUETOOTH`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2416808551
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2417037514
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2409886987
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2419245936
@raiden00pl could you try patch https://github.com/apache/nuttx/pull/14385, which could fix the incompatibility you mention here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "chengkai15 (via GitHub)" <gi...@apache.org>.
chengkai15 commented on code in PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#discussion_r1804040566
##########
arch/sim/src/sim/sim_hcisocket.c:
##########
@@ -332,35 +305,17 @@ int sim_bthcisock_register(int dev_id)
return -ENOMEM;
}
-#if defined(CONFIG_BLUETOOTH_BRIDGE)
- ret = bt_bridge_register(&dev->drv, &btdrv, &bledrv);
- if (ret < 0)
- {
- goto end;
- }
-
- ret = bthcisock_driver_register(btdrv, dev_id, true);
- if (ret < 0)
- {
- goto end;
- }
-
- ret = bthcisock_driver_register(bledrv, dev_id, false);
- if (ret < 0)
- {
- goto end;
- }
-
-end:
-#else
- ret = bthcisock_driver_register(&dev->drv, dev_id, true);
-#endif
-
+#ifdef CONFIG_DRIVERS_BLUETOOTH
+ ret = bt_driver_register_with_id(&dev->drv, dev_id);
if (ret < 0)
{
+ wlerr("bt_driver_register error: %d\n", ret);
bthcisock_free(dev);
return ret;
}
+#else
+# error "Please select CONFIG_DRIVERS_BLUETOOTH"
Review Comment:
done, like this
#else
# error "Please select CONFIG_DRIVERS_BLUETOOTH"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2419187586
this also break configurations that use `CONFIG_UART_BTH4` with `/dev/ttyHCI0` and this should be well documented in PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2413711762
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2417752428
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2419142688
@xiaoxiang781216 @chengkai15 `nrf52840-dk/sdc_nimble` is broken with this PR merged
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 merged PR #14224:
URL: https://github.com/apache/nuttx/pull/14224
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on code in PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#discussion_r1803627697
##########
drivers/wireless/bluetooth/bt_driver.c:
##########
@@ -62,7 +62,6 @@ static int bt_driver_register_internal(FAR struct bt_driver_s *driver,
#elif defined(CONFIG_NET_BLUETOOTH)
return bt_netdev_register(driver);
#else
Review Comment:
remove
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "chengkai15 (via GitHub)" <gi...@apache.org>.
chengkai15 commented on code in PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#discussion_r1804040566
##########
arch/sim/src/sim/sim_hcisocket.c:
##########
@@ -332,35 +305,17 @@ int sim_bthcisock_register(int dev_id)
return -ENOMEM;
}
-#if defined(CONFIG_BLUETOOTH_BRIDGE)
- ret = bt_bridge_register(&dev->drv, &btdrv, &bledrv);
- if (ret < 0)
- {
- goto end;
- }
-
- ret = bthcisock_driver_register(btdrv, dev_id, true);
- if (ret < 0)
- {
- goto end;
- }
-
- ret = bthcisock_driver_register(bledrv, dev_id, false);
- if (ret < 0)
- {
- goto end;
- }
-
-end:
-#else
- ret = bthcisock_driver_register(&dev->drv, dev_id, true);
-#endif
-
+#ifdef CONFIG_DRIVERS_BLUETOOTH
+ ret = bt_driver_register_with_id(&dev->drv, dev_id);
if (ret < 0)
{
+ wlerr("bt_driver_register error: %d\n", ret);
bthcisock_free(dev);
return ret;
}
+#else
+# error "Please select CONFIG_DRIVERS_BLUETOOTH"
Review Comment:
done, like this
```
#else
# error "Please select CONFIG_DRIVERS_BLUETOOTH"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "raiden00pl (via GitHub)" <gi...@apache.org>.
raiden00pl commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2419166952
CONFIG_DRIVERS_BLUETOOTH is not selected for `nrf52840-dk`. Did you verify that `CONFIG_DRIVERS_BLUETOOTH` is selected for ALL affected configurations ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2419173244
sorry, @chengkai15 please review the affect board and ensure it work as before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2413710546
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2417441536
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2418421924
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2412844544
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2415942294
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2413430048
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "xiaoxiang781216 (via GitHub)" <gi...@apache.org>.
xiaoxiang781216 commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2418308933
please normalize defconfig:
```
Cmake in present: nrf5340-dk/sdc_nimble_cpunet,CONFIG_ARM_TOOLCHAIN_GNU_EABI
Configuration/Tool: nrf5340-dk/sdc_nimble_cpunet,CONFIG_ARM_TOOLCHAIN_GNU_EABI
2024-10-16 20:31:45
------------------------------------------------------------------------------------
Cleaning...
Configuring...
Select HOST_LINUX=y
Disabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Enabling CONFIG_ARM_TOOLCHAIN_GNU_EABI
Building NuttX...
HEAD detached at pull/14224/merge
Changes not staged for commit:
(use "git add <file>..." to update what will be committed)
(use "git restore <file>..." to discard changes in working directory)
modified: boards/arm/nrf53/nrf5340-dk/configs/sdc_nimble_cpunet/defconfig
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2412841757
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2413964296
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2415566692
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] bluetooth: upload bt local bug fix and features [nuttx]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #14224:
URL: https://github.com/apache/nuttx/pull/14224#issuecomment-2418429843
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org