You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/28 00:34:32 UTC
[GitHub] [bookkeeper] pkumar-singh opened a new pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
pkumar-singh opened a new pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809
### Motivation
Migrating bookkeeper-server bookie tests to gradle.
### Changes
1. As per the naming convention name of test class/file Should be {FooFeature}Test as opposed to Test{FooFeature}
2. Migrating tests to gradle
Master Issue: #2640
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi edited a comment on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
nicoloboschi edited a comment on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929294377
@pkumar-singh other than github actions, are there any points (other than release procedure) to migrate?
If no, IMHO we can create a single PR migrating all GH tests and updating release guide, what do you think @eolivelli ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi edited a comment on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
nicoloboschi edited a comment on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929294377
@pkumar-singh other than github actions, are there any points (other than release procedure) to migrate?
If no, IMHO we can create a single PR migrating all GH tests and updating release guide, what do you think @eolivelli ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929925437
merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929424665
@eolivelli Absolutely. We are committed to moving everything to gradle before the next release.
I think I have already sent an email to dev@bookkeepr some time last week.
This week I am going migrate the build to gradle. Next week I will focus on release and documentation updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] pkumar-singh commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
pkumar-singh commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929424665
@eolivelli Absolutely. We are committed to moving everything to gradle before the next release.
I think I have already sent an email to dev@bookkeepr some time last week.
This week I am going migrate the build to gradle. Next week I will focus on release and documentation updates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929390508
@eolivelli - +1 to that. We should be able to complete the Gradle migration before next major release.
Will work with @pkumar-singh to make sure we complete the tasks for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929896995
The plan looks good to me, I think we can go ahead, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli merged pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
eolivelli merged pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] eolivelli commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929925437
merging
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929294377
@pkumar-singh other than github actions, are there any point (other than release procedure) to migrate?
If no, IMHO we can create a single PR migrating all GH tests and updating release guide, what do you think @eolivelli ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929390508
@eolivelli - +1 to that. We should be able to complete the Gradle migration before next major release.
Will work with @pkumar-singh to make sure we complete the tasks for it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] nicoloboschi commented on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929294377
@pkumar-singh other than github actions, are there any point (other than release procedure) to migrate?
If no, IMHO we can create a single PR migrating all GH tests and updating release guide, what do you think @eolivelli ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra edited a comment on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra edited a comment on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929390508
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra edited a comment on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra edited a comment on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929390508
@eolivelli - +1 to that. We should be able to complete the Gradle migration before next major release.
Will work with @pkumar-singh to make sure we complete the tasks for it.
Once the Github actions run correctly with Gradle, we will remove the actions with Maven, and then remove Maven altogether.
@nicoloboschi - any additional comments or thoughts about it?
FYI @ivankelly , @merlimat , @fpj
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hsaputra edited a comment on pull request #2809: ISSUE #2640: BP-43 Migrate bookkeepr-server org.apache.bookkeeper.bookie.* tests to gradle
Posted by GitBox <gi...@apache.org>.
hsaputra edited a comment on pull request #2809:
URL: https://github.com/apache/bookkeeper/pull/2809#issuecomment-929390508
@eolivelli - +1 to that. We should be able to complete the Gradle migration before next major release.
Will work with @pkumar-singh to make sure we complete the tasks for it.
Once the Github actions run correctly with Gradle, we will remove the actions with Maven, and then remove Maven altogether.
@nicoloboschi - any additional comments or thoughts about it?
FYI @ivankelly , @merlimat , @fpj , @dlg99
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org