[jira] [Comment Edited] (IGNITE-9419) Avoid saving cache configuration synchronously during PME

["Ilya Lantukh (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-9419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16605879#comment-16605879 ] 

Ilya Lantukh edited comment on IGNITE-9419 at 9/6/18 3:48 PM:
--------------------------------------------------------------

[~Jokser],
Thanks for contribution!

In my opinion, adding public-mutable GridDhtPartitionsExchangeFuture.registerCachesFuture breaks encapsulation. Is it possible to re-design your solution to make this field modifiable only by ExchangeFuture itself?

Also, please add tests for this functionality.


was (Author: ilantukh):
[~Jokser],
Thanks for contribution!

In my opinion, adding publicly-mutable GridDhtPartitionsExchangeFuture.registerCachesFuture breaks encapsulation. Is it possible to re-design your solution to make this field modifiable only by ExchangeFuture itself?

Also, please add tests for this functionality.

> Avoid saving cache configuration synchronously during PME
> ---------------------------------------------------------
>
>                 Key: IGNITE-9419
>                 URL: https://issues.apache.org/jira/browse/IGNITE-9419
>             Project: Ignite
>          Issue Type: Improvement
>          Components: cache
>    Affects Versions: 2.5
>            Reporter: Pavel Kovalenko
>            Assignee: Pavel Kovalenko
>            Priority: Major
>             Fix For: 2.7
>
>
> Currently, we save cache configuration during PME at the activation phase here org.apache.ignite.internal.processors.cache.CacheAffinitySharedManager.CachesInfo#updateCachesInfo . We should avoid this, as it performs operations to a disk. We should save it asynchronously or lazy.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)