You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Jesse Wilson (JIRA)" <ji...@apache.org> on 2009/07/08 00:53:14 UTC
[jira] Created: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Harmony's java.util.concurrent is out of date
---------------------------------------------
Key: HARMONY-6262
URL: https://issues.apache.org/jira/browse/HARMONY-6262
Project: Harmony
Issue Type: Bug
Components: Classlib
Affects Versions: 5.0M10
Reporter: Jesse Wilson
There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732442#action_12732442 ]
Mark Hindess commented on HARMONY-6262:
---------------------------------------
BTW, you shouldn't set your expectations based on this issue. By coincidence, I was/am looking at updating concurrent to fix the missing methods in the java6 tree so I already had a workspace with the new concurrent code This meant that I could compare the results of your patch with that (which was a smaller 271k diff) rather than trying to parse your entire patch.
For future reference, it would have been easier for us if you had provided the improvement in two parts - one for the upstream (either a patch or just instructions for replacing the current code with the updated version) and one for your additions (which would be something like the 271k diff I looked at).
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Assignee: Mark Hindess
> Fix For: 5.0M11
>
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess reassigned HARMONY-6262:
-------------------------------------
Assignee: Mark Hindess
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Assignee: Mark Hindess
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802806#action_12802806 ]
Hudson commented on HARMONY-6262:
---------------------------------
Integrated in Harmony-1.5-head-linux-x86_64 #600 (See [http://hudson.zones.apache.org/hudson/job/Harmony-1.5-head-linux-x86_64/600/])
Reverting part of commit r794678:
Applying patch from "[#] Harmony's java.util.concurrent is
out of date".
to put back Harmony implementation of CopyOnWriteArrayList.
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Assignee: Mark Hindess
> Fix For: 5.0M11
>
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732240#action_12732240 ]
Mark Hindess commented on HARMONY-6262:
---------------------------------------
Thanks Jesse. I've removed the empty file at r794900.
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Assignee: Mark Hindess
> Fix For: 5.0M11
>
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Sean Qiu (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12728474#action_12728474 ]
Sean Qiu commented on HARMONY-6262:
-----------------------------------
Cool, thanks very much for your contribution, Jesse.
If you need any help, please just let us know
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jesse Wilson updated HARMONY-6262:
----------------------------------
Attachment: JSR166-20090707.patch
Updates the concurrency package. Original public-domain licensed code is here:
http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/
http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/test/tck/
According to one of the contributors to that package, "the highest quality 1.5 java.util.concurrent you can get is by grabbing the latest Doug Lea CVS version (1.7) and removing any post 1.5 APIs, mostly by removing "public" from selected methods." That's pretty much what I've done here. I've also removed some 1.6- and 1.7-only code.
This patch is blocked by HARMONY-6264. If volunteers could apply that patch and fix both DRLVM and J9, that would be incredibly awesome.
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Jesse Wilson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12732192#action_12732192 ]
Jesse Wilson commented on HARMONY-6262:
---------------------------------------
Mark, thanks for fixing this. I reviewed the change and it looks fantastic! And I'm thrilled that you were able to apply such a significant change in a short time: it suggests very good things for future collaboration between Android and Harmony. Yay!
One tiny complaint: the patch intended to delete three files named "package.html". Unfortunately, SVN currently holds empty files for these. For example:
http://svn.apache.org/viewvc/harmony/enhanced/classlib/trunk/modules/concurrent/src/main/java/java/util/concurrent/package.html?view=log
Please remove the three package.html files at your leisure.
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Assignee: Mark Hindess
> Fix For: 5.0M11
>
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-6262) Harmony's java.util.concurrent is
out of date
Posted by "Mark Hindess (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-6262?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Hindess resolved HARMONY-6262.
-----------------------------------
Resolution: Fixed
Fix Version/s: 5.0M11
Patch applied at r794678. Please verify that it has been applied correctly and close this JIRA to confirm. Thanks very much for this improvement.
> Harmony's java.util.concurrent is out of date
> ---------------------------------------------
>
> Key: HARMONY-6262
> URL: https://issues.apache.org/jira/browse/HARMONY-6262
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Affects Versions: 5.0M10
> Reporter: Jesse Wilson
> Assignee: Mark Hindess
> Fix For: 5.0M11
>
> Attachments: JSR166-20090707.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There have been several performance enhancements and bug fixes to the JSR 166 code since it was originally copied into Harmony in 2006.
> http://gee.cs.oswego.edu/cgi-bin/viewcvs.cgi/jsr166/src/main/java/util/concurrent/
> I'll prepare a patch to bring Harmony up-to-date, which I'll can then use to bring Android up-to-date. We're tracking this here:
> http://code.google.com/p/android/issues/detail?id=3108
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.