You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "George Scott (JIRA)" <ji...@apache.org> on 2012/07/31 08:31:34 UTC

[jira] [Created] (VFS-435) Typo in FileSystemConfigBuilder

George Scott created VFS-435:
--------------------------------

             Summary: Typo in FileSystemConfigBuilder
                 Key: VFS-435
                 URL: https://issues.apache.org/jira/browse/VFS-435
             Project: Commons VFS
          Issue Type: Bug
    Affects Versions: 2.0
            Reporter: George Scott
            Priority: Minor


In FileSystemConfigBuilder there are two references to PREFIX.  These should probably be this.prefix.

*** FileSystemConfigBuilder.java~       2012-07-31 16:15:25.468750000 +1000
--- FileSystemConfigBuilder.java        2012-07-31 16:16:49.218750000 +1000
***************
*** 94,100 ****
      /** @since 2.0 */
      protected boolean hasObject(FileSystemOptions opts, String name)
      {
!         return hasParam(opts, name) || System.getProperties().containsKey(PREFIX + name);
      }

      /** @since 2.0 */
--- 94,100 ----
      /** @since 2.0 */
      protected boolean hasObject(FileSystemOptions opts, String name)
      {
!         return hasParam(opts, name) || System.getProperties().containsKey(this.prefix + name);
      }

      /** @since 2.0 */
***************
*** 115,121 ****
          Boolean value = (Boolean) getParam(opts, name);
          if (value == null)
          {
!             String str = System.getProperty(PREFIX + name);
              if (str == null)
              {
                  return defaultValue;
--- 115,121 ----
          Boolean value = (Boolean) getParam(opts, name);
          if (value == null)
          {
!             String str = System.getProperty(this.prefix + name);
              if (str == null)
              {
                  return defaultValue;


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (VFS-435) FileSystemConfigBuilder does not use prefix for some system property lookups.

Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory resolved VFS-435.
---------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1

commit -m "[VFS-435] FileSystemConfigBuilder does not use prefix for some system property lookups." C:/svn/org/apache/commons/trunks-proper/vfs/src/changes/changes.xml C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/FileSystemConfigBuilder.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/core/src/main/java/org/apache/commons/vfs2/FileSystemConfigBuilder.java
    Sending        C:/svn/org/apache/commons/trunks-proper/vfs/src/changes/changes.xml
    Transmitting file data ...
    Committed revision 1367517.
                
> FileSystemConfigBuilder does not use prefix for some system property lookups.
> -----------------------------------------------------------------------------
>
>                 Key: VFS-435
>                 URL: https://issues.apache.org/jira/browse/VFS-435
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: George Scott
>            Priority: Minor
>              Labels: patch
>             Fix For: 2.1
>
>         Attachments: FileSystemConfigBuilder.java.patch
>
>
> In FileSystemConfigBuilder there are two references to "PREFIX" that should probably be "this.prefix".  See attached patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VFS-435) Typo in FileSystemConfigBuilder

Posted by "George Scott (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Scott updated VFS-435:
-----------------------------

    Description: 
In FileSystemConfigBuilder there are two references to PREFIX.  These should probably be this.prefix.  See attached patch.


  was:
In FileSystemConfigBuilder there are two references to PREFIX.  These should probably be this.prefix.

*** FileSystemConfigBuilder.java~       2012-07-31 16:15:25.468750000 +1000
--- FileSystemConfigBuilder.java        2012-07-31 16:16:49.218750000 +1000
***************
*** 94,100 ****
      /** @since 2.0 */
      protected boolean hasObject(FileSystemOptions opts, String name)
      {
!         return hasParam(opts, name) || System.getProperties().containsKey(PREFIX + name);
      }

      /** @since 2.0 */
--- 94,100 ----
      /** @since 2.0 */
      protected boolean hasObject(FileSystemOptions opts, String name)
      {
!         return hasParam(opts, name) || System.getProperties().containsKey(this.prefix + name);
      }

      /** @since 2.0 */
***************
*** 115,121 ****
          Boolean value = (Boolean) getParam(opts, name);
          if (value == null)
          {
!             String str = System.getProperty(PREFIX + name);
              if (str == null)
              {
                  return defaultValue;
--- 115,121 ----
          Boolean value = (Boolean) getParam(opts, name);
          if (value == null)
          {
!             String str = System.getProperty(this.prefix + name);
              if (str == null)
              {
                  return defaultValue;


    
> Typo in FileSystemConfigBuilder
> -------------------------------
>
>                 Key: VFS-435
>                 URL: https://issues.apache.org/jira/browse/VFS-435
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: George Scott
>            Priority: Minor
>              Labels: patch
>         Attachments: FileSystemConfigBuilder.java.patch
>
>
> In FileSystemConfigBuilder there are two references to PREFIX.  These should probably be this.prefix.  See attached patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VFS-435) FileSystemConfigBuilder does not use prefix for some system property lookups.

Posted by "Gary D. Gregory (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gary D. Gregory updated VFS-435:
--------------------------------

    Summary: FileSystemConfigBuilder does not use prefix for some system property lookups.  (was: Typo in FileSystemConfigBuilder)
    
> FileSystemConfigBuilder does not use prefix for some system property lookups.
> -----------------------------------------------------------------------------
>
>                 Key: VFS-435
>                 URL: https://issues.apache.org/jira/browse/VFS-435
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: George Scott
>            Priority: Minor
>              Labels: patch
>         Attachments: FileSystemConfigBuilder.java.patch
>
>
> In FileSystemConfigBuilder there are two references to "PREFIX" that should probably be "this.prefix".  See attached patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VFS-435) Typo in FileSystemConfigBuilder

Posted by "George Scott (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Scott updated VFS-435:
-----------------------------

    Description: 
In FileSystemConfigBuilder there are two references to "PREFIX" that should probably be "this.prefix".  See attached patch.


  was:
In FileSystemConfigBuilder there are two references to PREFIX.  These should probably be this.prefix.  See attached patch.


    
> Typo in FileSystemConfigBuilder
> -------------------------------
>
>                 Key: VFS-435
>                 URL: https://issues.apache.org/jira/browse/VFS-435
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: George Scott
>            Priority: Minor
>              Labels: patch
>         Attachments: FileSystemConfigBuilder.java.patch
>
>
> In FileSystemConfigBuilder there are two references to "PREFIX" that should probably be "this.prefix".  See attached patch.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (VFS-435) Typo in FileSystemConfigBuilder

Posted by "George Scott (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/VFS-435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

George Scott updated VFS-435:
-----------------------------

    Attachment: FileSystemConfigBuilder.java.patch
    
> Typo in FileSystemConfigBuilder
> -------------------------------
>
>                 Key: VFS-435
>                 URL: https://issues.apache.org/jira/browse/VFS-435
>             Project: Commons VFS
>          Issue Type: Bug
>    Affects Versions: 2.0
>            Reporter: George Scott
>            Priority: Minor
>              Labels: patch
>         Attachments: FileSystemConfigBuilder.java.patch
>
>
> In FileSystemConfigBuilder there are two references to PREFIX.  These should probably be this.prefix.
> *** FileSystemConfigBuilder.java~       2012-07-31 16:15:25.468750000 +1000
> --- FileSystemConfigBuilder.java        2012-07-31 16:16:49.218750000 +1000
> ***************
> *** 94,100 ****
>       /** @since 2.0 */
>       protected boolean hasObject(FileSystemOptions opts, String name)
>       {
> !         return hasParam(opts, name) || System.getProperties().containsKey(PREFIX + name);
>       }
>       /** @since 2.0 */
> --- 94,100 ----
>       /** @since 2.0 */
>       protected boolean hasObject(FileSystemOptions opts, String name)
>       {
> !         return hasParam(opts, name) || System.getProperties().containsKey(this.prefix + name);
>       }
>       /** @since 2.0 */
> ***************
> *** 115,121 ****
>           Boolean value = (Boolean) getParam(opts, name);
>           if (value == null)
>           {
> !             String str = System.getProperty(PREFIX + name);
>               if (str == null)
>               {
>                   return defaultValue;
> --- 115,121 ----
>           Boolean value = (Boolean) getParam(opts, name);
>           if (value == null)
>           {
> !             String str = System.getProperty(this.prefix + name);
>               if (str == null)
>               {
>                   return defaultValue;

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira