[GitHub] [dolphinscheduler] EricGao888 commented on a diff in pull request #13011: [Bug-13010] [Task] The Flink SQL task page selects the pre-job deployment mode, but the task executed by the worker is the Flink local mode

[GitBox <gi...@apache.org>]

EricGao888 commented on code in PR #13011:
URL: https://github.com/apache/dolphinscheduler/pull/13011#discussion_r1032951200


##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java:
##########
@@ -126,7 +126,7 @@ public void testInitOptionsInClusterMode() throws Exception {
     @Test
     public void testInitOptionsInApplicationMode() throws Exception {

Review Comment:
   ```suggestion
       public void testInitOptionsInClusterMode() throws Exception {
   ```



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink-stream/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java:
##########
@@ -117,7 +117,7 @@ public void testRunSql() throws Exception {
     @Test
     public void testInitOptionsInClusterMode() throws Exception {

Review Comment:
   ```suggestion
       public void testInitOptionsInLocalMode() throws Exception {
   ```



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java:
##########
@@ -126,7 +126,7 @@ public void testInitOptionsInClusterMode() throws Exception {
     @Test
     public void testInitOptionsInApplicationMode() throws Exception {

Review Comment:
   ```suggestion
       public void testInitOptionsInClusterMode() throws Exception {
   ```



##########
dolphinscheduler-task-plugin/dolphinscheduler-task-flink/src/test/java/org/apache/dolphinscheduler/plugin/task/flink/FlinkArgsUtilsTest.java:
##########
@@ -117,7 +117,7 @@ public void testRunSql() throws Exception {
     @Test
     public void testInitOptionsInClusterMode() throws Exception {

Review Comment:
   ```suggestion
       public void testInitOptionsInLocalMode() throws Exception {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org