You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Alejandro Abdelnur <tu...@cloudera.com> on 2012/03/08 02:35:28 UTC
Re: Review Request: OOZIE-744, OOZIE-745, OOZIE-746, OOZIE-747 combo
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4236/
-----------------------------------------------------------
(Updated 2012-03-08 01:35:28.595268)
Review request for oozie.
Changes
-------
update 6 is a patch update including OOZIE-747 (compare against update 5 to see OOZIE-747 only)
Summary (updated)
-------
First patch is OOZIE-744
Second patch is OOZIE-744 + OOZIE-745
Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746
This addresses bugs OOZIE-744, OOZIE-745, OOZIE-746, and OOZIE-747.
https://issues.apache.org/jira/browse/OOZIE-744
https://issues.apache.org/jira/browse/OOZIE-745
https://issues.apache.org/jira/browse/OOZIE-746
https://issues.apache.org/jira/browse/OOZIE-747
Diffs (updated)
-----
trunk/core/src/main/conf/hadoop-conf/hadoop-site.xml PRE-CREATION
trunk/core/src/main/conf/hadoop-config.xml 1298218
trunk/core/src/main/conf/oozie-site.xml 1298218
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298218
trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218
trunk/core/src/main/resources/oozie-default.xml 1298218
trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1298218
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1298218
trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1298218
trunk/core/src/test/resources/hadoop-config.xml 1298218
trunk/docs/src/site/twiki/AG_HadoopConfiguration.twiki 1298218
trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1298218
Diff: https://reviews.apache.org/r/4236/diff
Testing
-------
run all tests against Hadoop 1
built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23
Thanks,
Alejandro
Re: Review Request: OOZIE-744, OOZIE-745, OOZIE-746, OOZIE-747 combo
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
> On 2012-03-08 21:10:25, Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java, line 172
> > <https://reviews.apache.org/r/4236/diff/6/?file=88979#file88979line172>
> >
> > How the absolute path is handled? if someone give full path as the Conf DIR.
you are correct, this is wrong, I've got confused with how the URL constructor does this resolution. will fix
> On 2012-03-08 21:10:25, Mohammad Islam wrote:
> > trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java, line 179
> > <https://reviews.apache.org/r/4236/diff/6/?file=88979#file88979line179>
> >
> > in place of printing only the directory name(confDir), it is better to report the absolute path something like "dir.getAbolutePath()"
ok will do
> On 2012-03-08 21:10:25, Mohammad Islam wrote:
> > trunk/core/src/test/resources/hadoop-config.xml, line 19
> > <https://reviews.apache.org/r/4236/diff/6/?file=89000#file89000line19>
> >
> > Not sure where this file will be used? the new file name is hadoop-site.xml
yes it is used. there was a hadoop-site.xml that is used by pig. didn't want to overload the use of it.
- Alejandro
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4236/#review5749
-----------------------------------------------------------
On 2012-03-08 01:35:28, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4236/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 01:35:28)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> First patch is OOZIE-744
> Second patch is OOZIE-744 + OOZIE-745
> Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746
>
>
> This addresses bugs OOZIE-744, OOZIE-745, OOZIE-746, and OOZIE-747.
> https://issues.apache.org/jira/browse/OOZIE-744
> https://issues.apache.org/jira/browse/OOZIE-745
> https://issues.apache.org/jira/browse/OOZIE-746
> https://issues.apache.org/jira/browse/OOZIE-747
>
>
> Diffs
> -----
>
> trunk/core/src/main/conf/hadoop-conf/hadoop-site.xml PRE-CREATION
> trunk/core/src/main/conf/hadoop-config.xml 1298218
> trunk/core/src/main/conf/oozie-site.xml 1298218
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218
> trunk/core/src/main/resources/oozie-default.xml 1298218
> trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1298218
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218
> trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1298218
> trunk/core/src/test/resources/hadoop-config.xml 1298218
> trunk/docs/src/site/twiki/AG_HadoopConfiguration.twiki 1298218
> trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1298218
>
> Diff: https://reviews.apache.org/r/4236/diff
>
>
> Testing
> -------
>
> run all tests against Hadoop 1
>
> built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-744, OOZIE-745, OOZIE-746, OOZIE-747 combo
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4236/#review5749
-----------------------------------------------------------
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4236/#comment12500>
How the absolute path is handled? if someone give full path as the Conf DIR.
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java
<https://reviews.apache.org/r/4236/#comment12498>
in place of printing only the directory name(confDir), it is better to report the absolute path something like "dir.getAbolutePath()"
trunk/core/src/test/resources/hadoop-config.xml
<https://reviews.apache.org/r/4236/#comment12499>
Not sure where this file will be used? the new file name is hadoop-site.xml
- Mohammad
On 2012-03-08 01:35:28, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4236/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 01:35:28)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> First patch is OOZIE-744
> Second patch is OOZIE-744 + OOZIE-745
> Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746
>
>
> This addresses bugs OOZIE-744, OOZIE-745, OOZIE-746, and OOZIE-747.
> https://issues.apache.org/jira/browse/OOZIE-744
> https://issues.apache.org/jira/browse/OOZIE-745
> https://issues.apache.org/jira/browse/OOZIE-746
> https://issues.apache.org/jira/browse/OOZIE-747
>
>
> Diffs
> -----
>
> trunk/core/src/main/conf/hadoop-conf/hadoop-site.xml PRE-CREATION
> trunk/core/src/main/conf/hadoop-config.xml 1298218
> trunk/core/src/main/conf/oozie-site.xml 1298218
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218
> trunk/core/src/main/resources/oozie-default.xml 1298218
> trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1298218
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218
> trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1298218
> trunk/core/src/test/resources/hadoop-config.xml 1298218
> trunk/docs/src/site/twiki/AG_HadoopConfiguration.twiki 1298218
> trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1298218
>
> Diff: https://reviews.apache.org/r/4236/diff
>
>
> Testing
> -------
>
> run all tests against Hadoop 1
>
> built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-743, OOZIE-744, OOZIE-746, OOZIE-747 combo
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4236/
-----------------------------------------------------------
(Updated 2012-03-09 04:49:13.744071)
Review request for oozie.
Changes
-------
correction on the JIRA numbers:
patch 1 is 743
patch 2 is 744
patches 3,4,5 are 745 & 746 (will close 745 as dup of 746)
patches 6,7 are 747
Summary (updated)
-------
First patch is OOZIE-744
Second patch is OOZIE-744 + OOZIE-745
Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746
This addresses bugs OOZIE-743, OOZIE-744, OOZIE-746, and OOZIE-747.
https://issues.apache.org/jira/browse/OOZIE-743
https://issues.apache.org/jira/browse/OOZIE-744
https://issues.apache.org/jira/browse/OOZIE-746
https://issues.apache.org/jira/browse/OOZIE-747
Diffs
-----
trunk/core/src/main/conf/hadoop-conf/hadoop-site.xml PRE-CREATION
trunk/core/src/main/conf/hadoop-config.xml 1298218
trunk/core/src/main/conf/oozie-site.xml 1298218
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298218
trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218
trunk/core/src/main/resources/oozie-default.xml 1298218
trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1298218
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1298218
trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1298218
trunk/core/src/test/resources/hadoop-config.xml 1298218
trunk/docs/src/site/twiki/AG_HadoopConfiguration.twiki 1298218
trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1298218
Diff: https://reviews.apache.org/r/4236/diff
Testing
-------
run all tests against Hadoop 1
built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23
Thanks,
Alejandro
Re: Review Request: OOZIE-744, OOZIE-745, OOZIE-746, OOZIE-747 combo
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4236/#review5764
-----------------------------------------------------------
Ship it!
+1
As mentioned in earlier comment, it will very helpful to make those code modularize. A new JIRA might be the next step.
- Mohammad
On 2012-03-08 21:38:25, Alejandro Abdelnur wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4236/
> -----------------------------------------------------------
>
> (Updated 2012-03-08 21:38:25)
>
>
> Review request for oozie.
>
>
> Summary
> -------
>
> First patch is OOZIE-744
> Second patch is OOZIE-744 + OOZIE-745
> Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746
>
>
> This addresses bugs OOZIE-744, OOZIE-745, OOZIE-746, and OOZIE-747.
> https://issues.apache.org/jira/browse/OOZIE-744
> https://issues.apache.org/jira/browse/OOZIE-745
> https://issues.apache.org/jira/browse/OOZIE-746
> https://issues.apache.org/jira/browse/OOZIE-747
>
>
> Diffs
> -----
>
> trunk/core/src/main/conf/hadoop-conf/hadoop-site.xml PRE-CREATION
> trunk/core/src/main/conf/hadoop-config.xml 1298218
> trunk/core/src/main/conf/oozie-site.xml 1298218
> trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 1298218
> trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298218
> trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218
> trunk/core/src/main/resources/oozie-default.xml 1298218
> trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1298218
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1298218
> trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1298218
> trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218
> trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1298218
> trunk/core/src/test/resources/hadoop-config.xml 1298218
> trunk/docs/src/site/twiki/AG_HadoopConfiguration.twiki 1298218
> trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1298218
>
> Diff: https://reviews.apache.org/r/4236/diff
>
>
> Testing
> -------
>
> run all tests against Hadoop 1
>
> built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23
>
>
> Thanks,
>
> Alejandro
>
>
Re: Review Request: OOZIE-744, OOZIE-745, OOZIE-746, OOZIE-747 combo
Posted by Alejandro Abdelnur <tu...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4236/
-----------------------------------------------------------
(Updated 2012-03-08 21:38:25.860278)
Review request for oozie.
Changes
-------
updated patch based on review feedback.
Summary
-------
First patch is OOZIE-744
Second patch is OOZIE-744 + OOZIE-745
Third patch is OOZIE-744 + OOZIE-745 + OOZIE-746
This addresses bugs OOZIE-744, OOZIE-745, OOZIE-746, and OOZIE-747.
https://issues.apache.org/jira/browse/OOZIE-744
https://issues.apache.org/jira/browse/OOZIE-745
https://issues.apache.org/jira/browse/OOZIE-746
https://issues.apache.org/jira/browse/OOZIE-747
Diffs (updated)
-----
trunk/core/src/main/conf/hadoop-conf/hadoop-site.xml PRE-CREATION
trunk/core/src/main/conf/hadoop-config.xml 1298218
trunk/core/src/main/conf/oozie-site.xml 1298218
trunk/core/src/main/java/org/apache/oozie/ErrorCode.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/FsELFunctions.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/action/hadoop/MapReduceActionExecutor.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/bundle/BundleSubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordActionInputCheckXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/coord/CoordSubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/ActionXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/SubmitXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/command/wf/WfEndXCommand.java 1298218
trunk/core/src/main/java/org/apache/oozie/coord/CoordELFunctions.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/AuthorizationService.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/HadoopAccessorService.java 1298218
trunk/core/src/main/java/org/apache/oozie/service/WorkflowAppService.java 1298218
trunk/core/src/main/java/org/apache/oozie/util/JobUtils.java 1298218
trunk/core/src/main/resources/oozie-default.xml 1298218
trunk/core/src/test/java/org/apache/oozie/action/TestActionFailover.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestDistCpActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestHiveActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestLauncher.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionError.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestPigActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestShellActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/action/hadoop/TestSqoopActionExecutor.java 1298218
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionCheckXCommand.java 1298218
trunk/core/src/test/java/org/apache/oozie/command/wf/TestActionStartXCommand.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestAuthorizationService.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestHadoopAccessorService.java 1298218
trunk/core/src/test/java/org/apache/oozie/service/TestRecoveryService.java 1298218
trunk/core/src/test/java/org/apache/oozie/test/XFsTestCase.java 1298218
trunk/core/src/test/java/org/apache/oozie/test/XTestCase.java 1298218
trunk/core/src/test/resources/hadoop-config.xml 1298218
trunk/docs/src/site/twiki/AG_HadoopConfiguration.twiki 1298218
trunk/examples/src/test/java/org/apache/oozie/example/TestLocalOozieExample.java 1298218
Diff: https://reviews.apache.org/r/4236/diff
Testing
-------
run all tests against Hadoop 1
built deployed Oozie and submitted a MR WF against Hadoop 1 and Hadoop 0.23
Thanks,
Alejandro