You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2021/03/01 19:33:13 UTC

[GitHub] [logging-log4j2] vy commented on pull request #471: LOG4J2-2948 Replace HashSet with IdentityHashMap in ParameterFormatter to detect cycles.

vy commented on pull request #471:
URL: https://github.com/apache/logging-log4j2/pull/471#issuecomment-788212187


   @rgoers, would you mind reviewing the changes, please? Note that I don't create a new `HashSet` for each internal call, which has used to be the case. According to tests, this should be fine.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org