You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/04/25 01:22:24 UTC
Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20380/
-----------------------------------------------------------
(Updated April 24, 2014, 11:22 p.m.)
Review request for kafka.
Summary (updated)
-----------------
Fix KAFKA-1395: Address Jun's comments
Bugs: KAFKA-1395
https://issues.apache.org/jira/browse/KAFKA-1395
Repository: kafka
Description (updated)
-------
minor fix 2
minor fix
Move create server/producer and create topic to setUp in LogRecoveryTest
Address Jun's comments
Incoporate Neha's comments
remove waitUntilLeaderIsElectedOrChanged
KAFKA-1395.v1
Diffs (updated)
-----
core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala 7125ec9c03e634d7625a315a944eaf5088074eed
core/src/test/scala/unit/kafka/integration/FetcherTest.scala 4075068a80d6e71a3446a579112541d5b4892854
core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala d1d969e6c7a5183fa9877fcd12cf49de0cead62a
core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 16e716440099d62198af3bbadaf5b7d7bc496735
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala addd11ab8be2a1c5de0e43f006de1087032fa6d8
core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
Diff: https://reviews.apache.org/r/20380/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20380/#review41521
-----------------------------------------------------------
Looks good. Just the following minor comment.
core/src/test/scala/unit/kafka/utils/TestUtils.scala
<https://reviews.apache.org/r/20380/#comment74967>
Could we add a comment on producerProps?
- Jun Rao
On April 25, 2014, 6:03 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20380/
> -----------------------------------------------------------
>
> (Updated April 25, 2014, 6:03 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1395
> https://issues.apache.org/jira/browse/KAFKA-1395
>
>
> Repository: kafka
>
>
> Description
> -------
>
> Address Jun's comments round two
>
>
> minor fix 2
>
>
> minor fix
>
>
> Move create server/producer and create topic to setUp in LogRecoveryTest
>
>
> Address Jun's comments
>
>
> Incoporate Neha's comments
>
>
> remove waitUntilLeaderIsElectedOrChanged
>
>
> KAFKA-1395.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala 7125ec9c03e634d7625a315a944eaf5088074eed
> core/src/test/scala/unit/kafka/integration/FetcherTest.scala 4075068a80d6e71a3446a579112541d5b4892854
> core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea
> core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala d1d969e6c7a5183fa9877fcd12cf49de0cead62a
> core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 16e716440099d62198af3bbadaf5b7d7bc496735
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
> core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
> core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala addd11ab8be2a1c5de0e43f006de1087032fa6d8
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
>
> Diff: https://reviews.apache.org/r/20380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20380/
-----------------------------------------------------------
(Updated April 25, 2014, 9:09 p.m.)
Review request for kafka.
Bugs: KAFKA-1395
https://issues.apache.org/jira/browse/KAFKA-1395
Repository: kafka
Description (updated)
-------
Added comments 2
Added comments
minor fix
Address Jun's comments round two
minor fix 2
minor fix
Move create server/producer and create topic to setUp in LogRecoveryTest
Address Jun's comments
Incoporate Neha's comments
remove waitUntilLeaderIsElectedOrChanged
KAFKA-1395.v1
Diffs (updated)
-----
core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala 7125ec9c03e634d7625a315a944eaf5088074eed
core/src/test/scala/unit/kafka/integration/FetcherTest.scala 4075068a80d6e71a3446a579112541d5b4892854
core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala d1d969e6c7a5183fa9877fcd12cf49de0cead62a
core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 16e716440099d62198af3bbadaf5b7d7bc496735
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 1b87acf11f48f81d1186f5eb2e00017079eaef60
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala faf466b4ed3d408e548db6e454f03020c2ff4808
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala addd11ab8be2a1c5de0e43f006de1087032fa6d8
core/src/test/scala/unit/kafka/utils/TestUtils.scala 498941d8d894fbb2120bfa10c5be1e046691f73b
Diff: https://reviews.apache.org/r/20380/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20380/
-----------------------------------------------------------
(Updated April 25, 2014, 6:03 p.m.)
Review request for kafka.
Bugs: KAFKA-1395
https://issues.apache.org/jira/browse/KAFKA-1395
Repository: kafka
Description (updated)
-------
Address Jun's comments round two
minor fix 2
minor fix
Move create server/producer and create topic to setUp in LogRecoveryTest
Address Jun's comments
Incoporate Neha's comments
remove waitUntilLeaderIsElectedOrChanged
KAFKA-1395.v1
Diffs (updated)
-----
core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala 7125ec9c03e634d7625a315a944eaf5088074eed
core/src/test/scala/unit/kafka/integration/FetcherTest.scala 4075068a80d6e71a3446a579112541d5b4892854
core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea
core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala d1d969e6c7a5183fa9877fcd12cf49de0cead62a
core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 16e716440099d62198af3bbadaf5b7d7bc496735
core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala addd11ab8be2a1c5de0e43f006de1087032fa6d8
core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
Diff: https://reviews.apache.org/r/20380/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 20380: Fix KAFKA-1395: Address Jun's comments
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20380/#review41472
-----------------------------------------------------------
Great cleanup patch! Some minor comments.
1. TestUtils.createProducer: Could we keep the props parameter and treat it as the list of properties that we want to override?
2. Unused imports in ServerShutdownTest and LogRecoveryTest.
- Jun Rao
On April 24, 2014, 11:22 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20380/
> -----------------------------------------------------------
>
> (Updated April 24, 2014, 11:22 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1395
> https://issues.apache.org/jira/browse/KAFKA-1395
>
>
> Repository: kafka
>
>
> Description
> -------
>
> minor fix 2
>
>
> minor fix
>
>
> Move create server/producer and create topic to setUp in LogRecoveryTest
>
>
> Address Jun's comments
>
>
> Incoporate Neha's comments
>
>
> remove waitUntilLeaderIsElectedOrChanged
>
>
> KAFKA-1395.v1
>
>
> Diffs
> -----
>
> core/src/test/scala/unit/kafka/integration/AutoOffsetResetTest.scala 7125ec9c03e634d7625a315a944eaf5088074eed
> core/src/test/scala/unit/kafka/integration/FetcherTest.scala 4075068a80d6e71a3446a579112541d5b4892854
> core/src/test/scala/unit/kafka/integration/ProducerConsumerTestHarness.scala 731ee59e67e302f4cb1da12b1d4ae7ff59010aea
> core/src/test/scala/unit/kafka/integration/UncleanLeaderElectionTest.scala d1d969e6c7a5183fa9877fcd12cf49de0cead62a
> core/src/test/scala/unit/kafka/javaapi/consumer/ZookeeperConsumerConnectorTest.scala 16e716440099d62198af3bbadaf5b7d7bc496735
> core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala 7a0ef6faeaa419553f912c8a6d44099818e19833
> core/src/test/scala/unit/kafka/server/ReplicaFetchTest.scala 481a400067ec97ed97a2bbd8506b34960a5ec000
> core/src/test/scala/unit/kafka/server/ServerShutdownTest.scala addd11ab8be2a1c5de0e43f006de1087032fa6d8
> core/src/test/scala/unit/kafka/utils/TestUtils.scala 130b6be8414268b9a992514ecbc7561872ccaca7
>
> Diff: https://reviews.apache.org/r/20380/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>