You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Adar Dembo (Code Review)" <ge...@cloudera.org> on 2018/04/20 22:20:04 UTC
[kudu-CR](branch-1.7.x) KUDU-2412: Fix python client compilation in el6 environments
Adar Dembo has uploaded this change for review. ( http://gerrit.cloudera.org:8080/10140
Change subject: KUDU-2412: Fix python client compilation in el6 environments
......................................................................
KUDU-2412: Fix python client compilation in el6 environments
This uses the C preprocessor to check the value of KUDU_INT128_SUPPORTED from the C++ headers
and defines a Cython macro PYKUDU_INT128_SUPPORTED.
PYKUDU_INT128_SUPPORTED is generated by
replacing the KUDU_INT128_SUPPORTED placeholder
in config.pxi.in to generate config.pxi which is then included
in client.pyx.
This is then used to conditionally generate the bits of Python code
that depend on int128-related methods.
See here for documentation:
http://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#conditional-statements
Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7
Reviewed-on: http://gerrit.cloudera.org:8080/10114
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 3a801d10438d7e247bf21c4923d46f386c4aa965)
---
M python/.gitignore
M python/kudu/__init__.py
M python/kudu/client.pyx
A python/kudu/config.pxi.in
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/setup.py
10 files changed, 127 insertions(+), 34 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/10140/1
--
To view, visit http://gerrit.cloudera.org:8080/10140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7
Gerrit-Change-Number: 10140
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.7.x) KUDU-2412: Fix python client compilation in el6 environments
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10140 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments
......................................................................
KUDU-2412: Fix python client compilation in el6 environments
This uses the C preprocessor to check the value of KUDU_INT128_SUPPORTED from the C++ headers
and defines a Cython macro PYKUDU_INT128_SUPPORTED.
PYKUDU_INT128_SUPPORTED is generated by
replacing the KUDU_INT128_SUPPORTED placeholder
in config.pxi.in to generate config.pxi which is then included
in client.pyx.
This is then used to conditionally generate the bits of Python code
that depend on int128-related methods.
See here for documentation:
http://cython.readthedocs.io/en/latest/src/userguide/language_basics.html#conditional-statements
Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7
Reviewed-on: http://gerrit.cloudera.org:8080/10114
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
(cherry picked from commit 3a801d10438d7e247bf21c4923d46f386c4aa965)
Reviewed-on: http://gerrit.cloudera.org:8080/10140
Tested-by: Adar Dembo <ad...@cloudera.com>
---
M python/.gitignore
M python/kudu/__init__.py
M python/kudu/client.pyx
A python/kudu/config.pxi.in
M python/kudu/libkudu_client.pxd
M python/kudu/schema.pyx
M python/kudu/tests/test_scanner.py
M python/kudu/tests/test_scantoken.py
M python/kudu/tests/util.py
M python/setup.py
10 files changed, 127 insertions(+), 34 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/10140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7
Gerrit-Change-Number: 10140
Gerrit-PatchSet: 2
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.7.x) KUDU-2412: Fix python client compilation in el6 environments
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10140 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments
......................................................................
Patch Set 1: Verified+1 Code-Review+2
Overriding Jenkins, thirdparty build issues due to broken workspaces.
--
To view, visit http://gerrit.cloudera.org:8080/10140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7
Gerrit-Change-Number: 10140
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 20 Apr 2018 22:56:48 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.7.x) KUDU-2412: Fix python client compilation in el6 environments
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/10140 )
Change subject: KUDU-2412: Fix python client compilation in el6 environments
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/10140
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.7.x
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ibd93b57020b80597baae9c8d3e0434c46f7fc3d7
Gerrit-Change-Number: 10140
Gerrit-PatchSet: 1
Gerrit-Owner: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>