You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/13 12:46:25 UTC
[GitHub] [incubator-shardingsphere] zjcnb opened a new pull request #5167:
Cmaster
zjcnb opened a new pull request #5167: Cmaster
URL: https://github.com/apache/incubator-shardingsphere/pull/5167
Fixes #5073.
multiple threads loads unconfigured data
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on issue #5167:
Cmaster
Posted by GitBox <gi...@apache.org>.
kimmking commented on issue #5167: Cmaster
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#issuecomment-612961331
plz change the title friendly for searching and fix ci test first.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [shardingsphere] kimmking commented on pull request #5167: multiple threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
kimmking commented on pull request #5167:
URL: https://github.com/apache/shardingsphere/pull/5167#issuecomment-621652640
we should let this pr done(merge or close), and move on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-shardingsphere] zjcnb commented on a change in pull
request #5167: multiple threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
zjcnb commented on a change in pull request #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#discussion_r408099381
##########
File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
##########
@@ -161,4 +167,32 @@ private TableMetaData decorate(final String tableName, final TableMetaData table
}
return result;
}
+
+ private Map<String, SchemaMetaData> asyncLoadSchemaMetaDataMap(final Map<String, DataSource> dataSourceMap, final int maxConnectionCount,
Review comment:
I will use ShardingSpehre's thread pool to transform SchemaMetaDataLoader.asyncLoad() method and RuleSchemaMetaDataLoader.asyncLoadSchemaMetaDataMap() method, How's that
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5167: multiple threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#discussion_r408084639
##########
File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
##########
@@ -161,4 +167,32 @@ private TableMetaData decorate(final String tableName, final TableMetaData table
}
return result;
}
+
+ private Map<String, SchemaMetaData> asyncLoadSchemaMetaDataMap(final Map<String, DataSource> dataSourceMap, final int maxConnectionCount,
Review comment:
this method is the same with org.apache.shardingsphere.sql.parser.binder.metadata.schema.SchemaMetaDataLoader， could we merge and keep one method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on issue #5167: multiple
threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#issuecomment-613385279
> Maybe we need consider about reuse ShardingSpehre's thread pool.
>
> FYI: org.apache.shardingsphere.underlying.executor.kernel.ExecutorKernel
I didn't see it before. Let me change it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on issue #5167: multiple
threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#issuecomment-613247611
> Cloud you change the title to make audience understand?
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] kimmking commented on a change in pull
request #5167: multiple threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
kimmking commented on a change in pull request #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#discussion_r409449594
##########
File path: shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java
##########
@@ -161,4 +167,32 @@ private TableMetaData decorate(final String tableName, final TableMetaData table
}
return result;
}
+
+ private Map<String, SchemaMetaData> asyncLoadSchemaMetaDataMap(final Map<String, DataSource> dataSourceMap, final int maxConnectionCount,
Review comment:
> I will use ShardingSpehre's thread pool to transform SchemaMetaDataLoader.asyncLoad() method and RuleSchemaMetaDataLoader.asyncLoadSchemaMetaDataMap() method, How's that
Reuse is a way?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] zjcnb commented on issue #5167: multiple
threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
zjcnb commented on issue #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#issuecomment-613247519
> plz change the title friendly for searching and fix ci test first.
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5167:
multiple threads loads unconfigured metadata
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5167: multiple threads loads unconfigured metadata
URL: https://github.com/apache/incubator-shardingsphere/pull/5167#issuecomment-613262239
## Pull Request Test Coverage Report for [Build 11024](https://coveralls.io/builds/30058809)
* **0** of **22** **(0.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage decreased (**-0.06%**) to **57.55%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shardingsphere-underlying/shardingsphere-common/src/main/java/org/apache/shardingsphere/underlying/common/metadata/schema/RuleSchemaMetaDataLoader.java](https://coveralls.io/builds/30058809/source?filename=shardingsphere-underlying%2Fshardingsphere-common%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Funderlying%2Fcommon%2Fmetadata%2Fschema%2FRuleSchemaMetaDataLoader.java#L86) | 0 | 22 | 0.0%
<!-- | **Total:** | **0** | **22** | **0.0%** | -->
| Totals | [](https://coveralls.io/builds/30058809) |
| :-- | --: |
| Change from base [Build 11021](https://coveralls.io/builds/30056459): | -0.06% |
| Covered Lines: | 11841 |
| Relevant Lines: | 20575 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services