[jira] Commented: (WW-1328) xhtml theme is hardcoded to use xhtml/controlfooter for all templates

["Don Brown (JIRA)" <ji...@apache.org>]

    [ http://issues.apache.org/struts/browse/WW-1328?page=comments#action_37774 ] 
            
Don Brown commented on WW-1328:
-------------------------------

I think we should do both.  For this ticket, I'll make the change to use the current theme, meaning when making a new theme, you have to copy over all the xhtml theme templates.

Then, if desired, someone can open a new ticket to implement a theme hierarchy system that makes it easier to create your own theme.

> xhtml theme is hardcoded to use xhtml/controlfooter for all templates
> ---------------------------------------------------------------------
>
>                 Key: WW-1328
>                 URL: http://issues.apache.org/struts/browse/WW-1328
>             Project: Struts 2
>          Issue Type: Bug
>          Components: Views
>    Affects Versions: WW 2.2.2
>            Reporter: Nick Hill
>         Assigned To: Don Brown
>             Fix For: 2.0.0
>
>
> If you look at one of the xhtml themes, for example, text.ftl, it is hard coded to use the xhtml controlfooter. This poses a problem for overridding the theme.
> Example xhtml/text.ftl:
> <#include "/${parameters.templateDir}/${parameters.theme}/controlheader.ftl" />
> <#include "/${parameters.templateDir}/simple/text.ftl" />
> <#include "/${parameters.templateDir}/xhtml/controlfooter.ftl" />
> Notice the controlfooter does not use ${parameters.theme} but rather is hard coded to xhtml. 

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/struts/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira