You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2023/01/06 07:13:03 UTC
[GitHub] [kyuubi] bowenliang123 opened a new pull request, #4109: Enforce max Java bytecode version in dependencies
bowenliang123 opened a new pull request, #4109:
URL: https://github.com/apache/kyuubi/pull/4109
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
1. If you add a feature, you can talk about the use case of it.
2. If you fix a bug, you can clarify why it is a bug.
-->
- Enforce max Java bytecode version in dependencies with `enforceBytecodeVersion` rule (https://www.mojohaus.org/extra-enforcer-rules/enforceBytecodeVersion.html)
- Prevent accidentally bumping or introducing maven dependencies a Java version over baseline (currently Java 8)
Currently, some dependencies remain on older versions for Java 8 compatibility. This enforceBytecodeVersion rule will help to enforce them aligning to Java 8.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [x] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4109: Enforce max Java bytecode version in maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#discussion_r1063249730
##########
pom.xml:
##########
@@ -212,6 +212,7 @@
<maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version>
<maven.plugin.download.version>1.6.6</maven.plugin.download.version>
+ <maven.plugin.enforcer.mojo.extra.rules.version>1.6.1</maven.plugin.enforcer.mojo.extra.rules.version>
Review Comment:
Under the premise of being identifiable, we prefer the short name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on pull request #4109: Enforce max Java bytecode version in dependencies
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#issuecomment-1373237457
For example, the lastest release version of Hikari is 5.0.1 required Java 11. If we bump it to 5.0.1, the enforcer will check `enforceBytecodeVersion` rule and fails with the error message.
```
[INFO] Restricted to JDK 8 yet com.zaxxer:HikariCP:jar:5.0.1:compile contains com/zaxxer/hikari/HikariConfig.class targeted to JDK 11
[ERROR] Rule 1: org.apache.maven.plugins.enforcer.EnforceBytecodeVersion failed with message:
Found Banned Dependency: com.zaxxer:HikariCP:jar:5.0.1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on a diff in pull request #4109: Enforce max Java bytecode version in maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
pan3793 commented on code in PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#discussion_r1063224513
##########
pom.xml:
##########
@@ -212,6 +212,7 @@
<maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version>
<maven.plugin.download.version>1.6.6</maven.plugin.download.version>
+ <maven.plugin.enforcer.mojo.extra.rules.version>1.6.1</maven.plugin.enforcer.mojo.extra.rules.version>
Review Comment:
maven.plugin.enforcer.extra.rules.version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4109: Enforce max Java bytecode version in maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#discussion_r1063251086
##########
pom.xml:
##########
@@ -212,6 +212,7 @@
<maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version>
<maven.plugin.download.version>1.6.6</maven.plugin.download.version>
+ <maven.plugin.enforcer.mojo.extra.rules.version>1.6.1</maven.plugin.enforcer.mojo.extra.rules.version>
Review Comment:
What about `maven.plugin.enforcer.mojo.rules.version` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 closed pull request #4109: Enforce max Java bytecode version in Maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
pan3793 closed pull request #4109: Enforce max Java bytecode version in Maven dependencies with `enforceBytecodeVersion` rule
URL: https://github.com/apache/kyuubi/pull/4109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4109: Enforce max Java bytecode version in maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#discussion_r1063230567
##########
pom.xml:
##########
@@ -212,6 +212,7 @@
<maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version>
<maven.plugin.download.version>1.6.6</maven.plugin.download.version>
+ <maven.plugin.enforcer.mojo.extra.rules.version>1.6.1</maven.plugin.enforcer.mojo.extra.rules.version>
Review Comment:
`mojo` should be kept in the prop name, as `org.codehaus.mojo:extra-enforcer-rules` is third-party rules set provider to mavn enforcer plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4109: Enforce max Java bytecode version in maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#discussion_r1063230567
##########
pom.xml:
##########
@@ -212,6 +212,7 @@
<maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version>
<maven.plugin.download.version>1.6.6</maven.plugin.download.version>
+ <maven.plugin.enforcer.mojo.extra.rules.version>1.6.1</maven.plugin.enforcer.mojo.extra.rules.version>
Review Comment:
`mojo` should be kept in the prop name, as `org.codehaus.mojo:extra-enforcer-rules` is third-party rules set provider to mavn enforcer plugin from `[MojoHaus](https://www.mojohaus.org/)`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] bowenliang123 commented on a diff in pull request #4109: Enforce max Java bytecode version in maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
bowenliang123 commented on code in PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#discussion_r1063230567
##########
pom.xml:
##########
@@ -212,6 +212,7 @@
<maven.plugin.build.helper.version>3.2.0</maven.plugin.build.helper.version>
<maven.plugin.download.version>1.6.6</maven.plugin.download.version>
+ <maven.plugin.enforcer.mojo.extra.rules.version>1.6.1</maven.plugin.enforcer.mojo.extra.rules.version>
Review Comment:
`mojo` should be kept in the prop name, as `org.codehaus.mojo:extra-enforcer-rules` is third-party rules provider for mavn enforcer plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
[GitHub] [kyuubi] pan3793 commented on pull request #4109: Enforce max Java bytecode version in Maven dependencies with `enforceBytecodeVersion` rule
Posted by GitBox <gi...@apache.org>.
pan3793 commented on PR #4109:
URL: https://github.com/apache/kyuubi/pull/4109#issuecomment-1374832721
Thanks, merged to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org