You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Ryota Egashira <eg...@yahoo-inc.com> on 2012/11/09 08:59:02 UTC
Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/
-----------------------------------------------------------
Review request for oozie.
Description
-------
note still work in progress, with lots of comment out.
https://issues.apache.org/jira/browse/OOZIE-1043
This addresses bug OOZIE-1043.
https://issues.apache.org/jira/browse/OOZIE-1043
Diffs
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1406870
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1406870
branches/hcat-intre/core/src/main/java/org/apache/oozie/util/HCatURI.java 1406870
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
Diff: https://reviews.apache.org/r/7985/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/#review13542
-----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment29097>
minor comment: please rename the variable 'tmp' tp something meaningful.
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment29099>
minor: 'fals' is too generic. give some meaningful var name.
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment29098>
Please use HCatURI static method for verifying is something starts with hcat://
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment29100>
it appears the "formatting was not applied to the patch.
Please apple the oozie-formatting.xml file int he project level.
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment29101>
should we return here?
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment29103>
Wandering : is there any other place where we use the similar code (most possibly partitionAvailable()). If yes, we could reuse some of those pieces of code.
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment29102>
do we need to check if uri.length() > 0 before calling it.
- Mohammad Islam
On Nov. 16, 2012, 8:05 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7985/
> -----------------------------------------------------------
>
> (Updated Nov. 16, 2012, 8:05 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> note still work in progress, with lots of comment out.
> https://issues.apache.org/jira/browse/OOZIE-1043
>
>
> This addresses bug OOZIE-1043.
> https://issues.apache.org/jira/browse/OOZIE-1043
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
> branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
>
> Diff: https://reviews.apache.org/r/7985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/#review13604
-----------------------------------------------------------
Ship it!
+1 committing
- Mohammad Islam
On Nov. 20, 2012, 12:56 a.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7985/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2012, 12:56 a.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> note still work in progress, with lots of comment out.
> https://issues.apache.org/jira/browse/OOZIE-1043
>
>
> This addresses bug OOZIE-1043.
> https://issues.apache.org/jira/browse/OOZIE-1043
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
> branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
>
> Diff: https://reviews.apache.org/r/7985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/
-----------------------------------------------------------
(Updated Nov. 20, 2012, 12:56 a.m.)
Review request for oozie.
Changes
-------
with small change
Description
-------
note still work in progress, with lots of comment out.
https://issues.apache.org/jira/browse/OOZIE-1043
This addresses bug OOZIE-1043.
https://issues.apache.org/jira/browse/OOZIE-1043
Diffs (updated)
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
Diff: https://reviews.apache.org/r/7985/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/
-----------------------------------------------------------
(Updated Nov. 19, 2012, 9:44 p.m.)
Review request for oozie.
Changes
-------
accomodated Mohammad's comments. thanks!
Description
-------
note still work in progress, with lots of comment out.
https://issues.apache.org/jira/browse/OOZIE-1043
This addresses bug OOZIE-1043.
https://issues.apache.org/jira/browse/OOZIE-1043
Diffs (updated)
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
Diff: https://reviews.apache.org/r/7985/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/
-----------------------------------------------------------
(Updated Nov. 16, 2012, 8:05 p.m.)
Review request for oozie.
Changes
-------
revised patch based on Mohammad's comments.
Description
-------
note still work in progress, with lots of comment out.
https://issues.apache.org/jira/browse/OOZIE-1043
This addresses bug OOZIE-1043.
https://issues.apache.org/jira/browse/OOZIE-1043
Diffs (updated)
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
Diff: https://reviews.apache.org/r/7985/diff/
Testing
-------
Thanks,
Ryota Egashira
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Mohammad Islam <mi...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/#review13452
-----------------------------------------------------------
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment28818>
it should be getPushmissingdependency
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment28821>
since it will come from push missing dependency, it is expected to be HCatURI. We might need to add a combo method that deals with list of uris instead of one uri.
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java
<https://reviews.apache.org/r/7985/#comment28820>
what will happen to else. at least add some log.info
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java
<https://reviews.apache.org/r/7985/#comment28823>
in addition, some place you need to store the chat based dependency list into pushMisiisgDep field.
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28824>
else part?
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28825>
same else part?
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28826>
ditto
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28827>
ditto
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java
<https://reviews.apache.org/r/7985/#comment28828>
ditto
- Mohammad Islam
On Nov. 14, 2012, 8:25 p.m., Ryota Egashira wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7985/
> -----------------------------------------------------------
>
> (Updated Nov. 14, 2012, 8:25 p.m.)
>
>
> Review request for oozie.
>
>
> Description
> -------
>
> note still work in progress, with lots of comment out.
> https://issues.apache.org/jira/browse/OOZIE-1043
>
>
> This addresses bug OOZIE-1043.
> https://issues.apache.org/jira/browse/OOZIE-1043
>
>
> Diffs
> -----
>
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
> branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
> branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
> branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
> branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
>
> Diff: https://reviews.apache.org/r/7985/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ryota Egashira
>
>
Re: Review Request: Add logic to register to Missing Dependency Structure in
coord action materialization
Posted by Ryota Egashira <eg...@yahoo-inc.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7985/
-----------------------------------------------------------
(Updated Nov. 14, 2012, 8:25 p.m.)
Review request for oozie.
Changes
-------
1. add registerPartition in CoordCommandUtils, which is called from CoordMaterializeTransitionXCommand
2. add removeActionFromMissingPartitions in PDMS (not directly used in this patch, but needed)
3. changed partition separator in test cases of PDMS.
Description
-------
note still work in progress, with lots of comment out.
https://issues.apache.org/jira/browse/OOZIE-1043
This addresses bug OOZIE-1043.
https://issues.apache.org/jira/browse/OOZIE-1043
Diffs (updated)
-----
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordCommandUtils.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/command/coord/CoordMaterializeTransitionXCommand.java 1409046
branches/hcat-intre/core/src/main/java/org/apache/oozie/service/PartitionDependencyManagerService.java 1409046
branches/hcat-intre/core/src/test/java/org/apache/oozie/coord/TestCoordCommandUtils.java PRE-CREATION
branches/hcat-intre/core/src/test/java/org/apache/oozie/service/TestPartitionDependencyManagerService.java 1409046
Diff: https://reviews.apache.org/r/7985/diff/
Testing
-------
Thanks,
Ryota Egashira