You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "Brandon Enochs (JIRA)" <ji...@codehaus.org> on 2010/09/29 18:18:39 UTC
[jira] Created: (MRELEASE-601) The Maven 2 release plugin modifies
CDATA elements in pom.xml files.
The Maven 2 release plugin modifies CDATA elements in pom.xml files.
--------------------------------------------------------------------
Key: MRELEASE-601
URL: http://jira.codehaus.org/browse/MRELEASE-601
Project: Maven 2.x Release Plugin
Issue Type: Bug
Affects Versions: 2.0-beta-7
Reporter: Brandon Enochs
Priority: Blocker
Attachments: pom.xml
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-601) The Maven 2 release plugin modifies CDATA
elements in pom.xml files.
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286100#comment-286100 ]
Arnaud Heritier commented on MRELEASE-601:
------------------------------------------
I confirm that it adds spaces in the 2.0 release. I will test with a more recent version
{code}
- <replacetoken><![CDATA[<distributable/>]]></replacetoken>
- <replacevalue><![CDATA[<distributable/>
+ <replacetoken><![CDATA[<distributable />]]></replacetoken>
+ <replacevalue><![CDATA[<distributable />
{code}
> The Maven 2 release plugin modifies CDATA elements in pom.xml files.
> --------------------------------------------------------------------
>
> Key: MRELEASE-601
> URL: https://jira.codehaus.org/browse/MRELEASE-601
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-7
> Reporter: Brandon Enochs
> Priority: Blocker
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (MRELEASE-601) The Maven 2 release plugin
modifies CDATA elements in pom.xml files.
Posted by "Brett Porter (JIRA)" <ji...@codehaus.org>.
[ http://jira.codehaus.org/browse/MRELEASE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=236923#action_236923 ]
Brett Porter commented on MRELEASE-601:
---------------------------------------
have you tried this with a more recent version of the plugin?
> The Maven 2 release plugin modifies CDATA elements in pom.xml files.
> --------------------------------------------------------------------
>
> Key: MRELEASE-601
> URL: http://jira.codehaus.org/browse/MRELEASE-601
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-7
> Reporter: Brandon Enochs
> Priority: Blocker
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-601) The Maven 2 release plugin modifies CDATA
elements in pom.xml files.
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robert Scholte updated MRELEASE-601:
------------------------------------
Component/s: prepare
> The Maven 2 release plugin modifies CDATA elements in pom.xml files.
> --------------------------------------------------------------------
>
> Key: MRELEASE-601
> URL: https://jira.codehaus.org/browse/MRELEASE-601
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Components: prepare
> Affects Versions: 2.0-beta-7
> Reporter: Brandon Enochs
> Priority: Blocker
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-601) The Maven 2 release plugin modifies CDATA
elements in pom.xml files.
Posted by "Robert Scholte (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=288154#comment-288154 ]
Robert Scholte commented on MRELEASE-601:
-----------------------------------------
The last line seems to be the cause:
{code}
// we need to eliminate any extra whitespace inside elements, as JDOM will nuke it
content = content.replaceAll( "<([^!][^>]*?)\\s{2,}([^>]*?)>", "<$1 $2>" );
content = content.replaceAll( "(\\s{2,}|[^\\s])/>", "$1 />" );
{code}
I think it should be
{code}
content = content.replaceAll( "(\\s{2,})/>", "$1 />" );
{code}
I've tried it with Arnaud's testcase and with the adjustment all other tests still succeed.
Unless somebody can explain the reason of this part of the regular expression, I'll fix the issue like this.
> The Maven 2 release plugin modifies CDATA elements in pom.xml files.
> --------------------------------------------------------------------
>
> Key: MRELEASE-601
> URL: https://jira.codehaus.org/browse/MRELEASE-601
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-7
> Reporter: Brandon Enochs
> Priority: Blocker
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] (MRELEASE-601) The Maven 2 release plugin modifies CDATA
elements in pom.xml files.
Posted by "Arnaud Heritier (JIRA)" <ji...@codehaus.org>.
[ https://jira.codehaus.org/browse/MRELEASE-601?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=286111#comment-286111 ]
Arnaud Heritier commented on MRELEASE-601:
------------------------------------------
Reproduced with 2.2.1
> The Maven 2 release plugin modifies CDATA elements in pom.xml files.
> --------------------------------------------------------------------
>
> Key: MRELEASE-601
> URL: https://jira.codehaus.org/browse/MRELEASE-601
> Project: Maven 2.x Release Plugin
> Issue Type: Bug
> Affects Versions: 2.0-beta-7
> Reporter: Brandon Enochs
> Priority: Blocker
> Attachments: pom.xml
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://jira.codehaus.org/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira