You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/03/10 10:51:55 UTC

[GitHub] [pulsar] yjshen opened a new pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

yjshen opened a new pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513
 
 
   Currently, many modules depend on `managed-ledger-test.jar` just because they want to use MockBookkeeper and MockZookeeper.  This made module dependencies hard to understand and track.
   
   This PR introduces a new `testmocks` module and pulls all mocks from managed-ledger tests into the new module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597097058
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597046430
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597046430
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen closed pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen closed pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597068621
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597077649
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597097058
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597061341
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] tuteng commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
tuteng commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-609529766
 
 
   Add label release/2.5.1

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597068621
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen commented on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597384068
 
 
   @sijie PTAL

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597077649
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] sijie merged pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
sijie merged pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen opened a new pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen opened a new pull request #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513
 
 
   Currently, many modules depend on `managed-ledger-test.jar` just because they want to use MockBookkeeper and MockZookeeper.  This made module dependencies hard to understand and track.
   
   This PR introduces a new `testmocks` module and pulls all mocks from managed-ledger tests into the new module.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [pulsar] yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible

Posted by GitBox <gi...@apache.org>.
yjshen removed a comment on issue #6513: [Maven Cleanup] Remove managed-ledger and zk-utils test-jar dependencies when possible
URL: https://github.com/apache/pulsar/pull/6513#issuecomment-597061341
 
 
   /pulsarbot run-failure-checks

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services