You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@yunikorn.apache.org by "wusamzong (via GitHub)" <gi...@apache.org> on 2023/02/17 05:10:04 UTC

[GitHub] [yunikorn-k8shim] wusamzong opened a new pull request, #536: [YUNIKORN-1583] Verify_Multiple_TaskGroups_Nodes test is flaky

wusamzong opened a new pull request, #536:
URL: https://github.com/apache/yunikorn-k8shim/pull/536

   ### What is this PR for?
   Increase the waiting time for Pod Terminated and Pod Running
   
   ### What type of PR is it?
   * [x] - sub-task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-1583/
   
   ### How should this be tested?
   `ginkgo -r -v -timeout=2h -- -yk-namespace "yunikorn" -kube-config "$HOME/.kube/config"`
   
   ### Screenshots (if appropriate)
   ![image](https://user-images.githubusercontent.com/48400525/219554459-9ee737a9-4230-40b9-ab23-cf5372a82901.png)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-k8shim] codecov[bot] commented on pull request #536: [YUNIKORN-1583] Verify_Multiple_TaskGroups_Nodes test is flaky

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #536:
URL: https://github.com/apache/yunikorn-k8shim/pull/536#issuecomment-1434117761

   # [Codecov](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#536](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (cc8f914) into [master](https://codecov.io/gh/apache/yunikorn-k8shim/commit/a9cdd44d9785c883f6bf4e0a926b824368132767?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a9cdd44) will **increase** coverage by `0.10%`.
   > The diff coverage is `n/a`.
   
   ```diff
   @@            Coverage Diff             @@
   ##           master     #536      +/-   ##
   ==========================================
   + Coverage   69.41%   69.52%   +0.10%     
   ==========================================
     Files          45       45              
     Lines        7714     7715       +1     
   ==========================================
   + Hits         5355     5364       +9     
   + Misses       2162     2155       -7     
   + Partials      197      196       -1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [pkg/dispatcher/dispatcher.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2Rpc3BhdGNoZXIvZGlzcGF0Y2hlci5nbw==) | `74.82% <0.00%> (-1.40%)` | :arrow_down: |
   | [pkg/common/si\_helper.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9zaV9oZWxwZXIuZ28=) | `97.60% <0.00%> (+0.04%)` | :arrow_up: |
   | [pkg/common/resource.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NvbW1vbi9yZXNvdXJjZS5nbw==) | `82.29% <0.00%> (+0.87%)` | :arrow_up: |
   | [pkg/cache/task.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL3Rhc2suZ28=) | `68.81% <0.00%> (+1.00%)` | :arrow_up: |
   | [pkg/cache/nodes.go](https://codecov.io/gh/apache/yunikorn-k8shim/pull/536?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGtnL2NhY2hlL25vZGVzLmdv) | `81.81% <0.00%> (+2.08%)` | :arrow_up: |
   
   :mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [yunikorn-k8shim] wusamzong closed pull request #536: [YUNIKORN-1583] Verify_Multiple_TaskGroups_Nodes test is flaky

Posted by "wusamzong (via GitHub)" <gi...@apache.org>.
wusamzong closed pull request #536: [YUNIKORN-1583] Verify_Multiple_TaskGroups_Nodes test is flaky
URL: https://github.com/apache/yunikorn-k8shim/pull/536


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org