You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Mohit Sabharwal (JIRA)" <ji...@apache.org> on 2017/07/06 01:38:01 UTC

[jira] [Commented] (HIVE-17048) Pass HiveOperation info to HiveSemanticAnalyzerHook through HiveSemanticAnalyzerHookContext

    [ https://issues.apache.org/jira/browse/HIVE-17048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16075769#comment-16075769 ] 

Mohit Sabharwal commented on HIVE-17048:
----------------------------------------

Good to add the operation type to TestHs2Hooks and TestHs2HooksWithMiniKdc unit tests as well (see HIVE-8338)
LGTM, otherwise.

> Pass HiveOperation info to HiveSemanticAnalyzerHook through HiveSemanticAnalyzerHookContext
> -------------------------------------------------------------------------------------------
>
>                 Key: HIVE-17048
>                 URL: https://issues.apache.org/jira/browse/HIVE-17048
>             Project: Hive
>          Issue Type: Improvement
>          Components: Hooks
>    Affects Versions: 2.1.1
>            Reporter: Aihua Xu
>            Assignee: Aihua Xu
>         Attachments: HIVE-17048.1.patch
>
>
> Currently hive passes the following info to HiveSemanticAnalyzerHook through HiveSemanticAnalyzerHookContext (see https://github.com/apache/hive/blob/master/ql/src/java/org/apache/hadoop/hive/ql/Driver.java#L553). But the operation type (HiveOperation) is also needed in some cases, e.g., when integrating with Sentry. 
> {noformat}
>         hookCtx.setConf(conf);
>         hookCtx.setUserName(userName);
>         hookCtx.setIpAddress(SessionState.get().getUserIpAddress());
>         hookCtx.setCommand(command);
> {noformat}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)