You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pirk.apache.org by smarthi <gi...@git.apache.org> on 2016/08/18 17:53:54 UTC
[GitHub] incubator-pirk issue #65: [PIRK-53] [WIP] - Fix LICENSE and NOTICE Files for...
Github user smarthi commented on the issue:
https://github.com/apache/incubator-pirk/pull/65
+1 to merge, given that most of the feedback has been addressed now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] incubator-pirk issue #65: [PIRK-53] [WIP] - Fix LICENSE
and NOTICE Files for...
Posted by Tim Ellison <t....@gmail.com>.
I'll answer on the other mail thread "Re: Source JAR vs. Convenience
binary JAR license files"
On 19/08/16 13:15, Ellison Anne Williams wrote:
> Yes, the PR is ready. As in the email that I sent yesterday, it's not the
> most elegant solution, but it seems to satisfy the requirements.
>
> On Fri, Aug 19, 2016 at 6:54 AM, Tim Ellison <t....@gmail.com> wrote:
>
>> On 18/08/16 18:53, smarthi wrote:
>>> Github user smarthi commented on the issue:
>>>
>>> https://github.com/apache/incubator-pirk/pull/65
>>>
>>> +1 to merge, given that most of the feedback has been addressed now.
>>
>> Really? I have not done a thorough review, but a quick build of
>> remotes/ellisonanne/pirk-53 looked like there is still more to do.
>>
>> I'm waiting for Ellison Anne to declare when the PR is ready for further
>> scrutiny.
>>
>> Regards,
>> Tim
>>
>
Re: [GitHub] incubator-pirk issue #65: [PIRK-53] [WIP] - Fix LICENSE
and NOTICE Files for...
Posted by Ellison Anne Williams <ea...@gmail.com>.
Yes, the PR is ready. As in the email that I sent yesterday, it's not the
most elegant solution, but it seems to satisfy the requirements.
On Fri, Aug 19, 2016 at 6:54 AM, Tim Ellison <t....@gmail.com> wrote:
> On 18/08/16 18:53, smarthi wrote:
> > Github user smarthi commented on the issue:
> >
> > https://github.com/apache/incubator-pirk/pull/65
> >
> > +1 to merge, given that most of the feedback has been addressed now.
>
> Really? I have not done a thorough review, but a quick build of
> remotes/ellisonanne/pirk-53 looked like there is still more to do.
>
> I'm waiting for Ellison Anne to declare when the PR is ready for further
> scrutiny.
>
> Regards,
> Tim
>
Re: [GitHub] incubator-pirk issue #65: [PIRK-53] [WIP] - Fix LICENSE
and NOTICE Files for...
Posted by Tim Ellison <t....@gmail.com>.
On 18/08/16 18:53, smarthi wrote:
> Github user smarthi commented on the issue:
>
> https://github.com/apache/incubator-pirk/pull/65
>
> +1 to merge, given that most of the feedback has been addressed now.
Really? I have not done a thorough review, but a quick build of
remotes/ellisonanne/pirk-53 looked like there is still more to do.
I'm waiting for Ellison Anne to declare when the PR is ready for further
scrutiny.
Regards,
Tim