You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/13 03:34:56 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6895: ui: fix guest traffic vlan input
shwstppr opened a new pull request, #6895:
URL: https://github.com/apache/cloudstack/pull/6895
S### Description
Fixes VLAN input while adding guest traffic type for the physical network in the zone wizard
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895#issuecomment-1312630726
@acs-robot a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rohityadavcloud merged pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
rohityadavcloud merged PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895#issuecomment-1312695271
@shwstppr is this fixing a github issue? If not, can you add a bit more test info for those not familiar with the issue, please?
> S### Description
>
> Fixes VLAN input while adding guest traffic type for the physical network in the zone wizard
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895#issuecomment-1312631525
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/6895 (LL-JID-234)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
shwstppr commented on PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895#issuecomment-1312849005
Updated description @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] acs-robot commented on pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
acs-robot commented on PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895#issuecomment-1312630698
Found UI changes, kicking a new UI QA build
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6895: ui: fix guest traffic vlan input
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6895:
URL: https://github.com/apache/cloudstack/pull/6895#issuecomment-1312649371
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6895?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6895](https://codecov.io/gh/apache/cloudstack/pull/6895?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b07c28b) into [4.17](https://codecov.io/gh/apache/cloudstack/commit/296035d9a57caa62260a666da726ec45b6801c4b?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (296035d) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## 4.17 #6895 +/- ##
============================================
- Coverage 10.34% 10.34% -0.01%
+ Complexity 6610 6609 -1
============================================
Files 2451 2451
Lines 242340 242340
Branches 37924 37924
============================================
- Hits 25070 25061 -9
- Misses 214182 214192 +10
+ Partials 3088 3087 -1
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6895?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rg/apache/cloudstack/quota/QuotaStatementImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6895/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL1F1b3RhU3RhdGVtZW50SW1wbC5qYXZh) | `36.28% <0.00%> (-3.99%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org