[GitHub] [zeppelin] cuspymd commented on a change in pull request #4150: [ZEPPELIN-5425] Polish Interpreter class

[GitBox <gi...@apache.org>]

cuspymd commented on a change in pull request #4150:
URL: https://github.com/apache/zeppelin/pull/4150#discussion_r662392195



##########
File path: zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/AbstractInterpreter.java
##########
@@ -47,6 +51,35 @@ public InterpreterResult interpret(String st,
     return internalInterpret(st, context);
   }
 
+  static String interpolate(String cmd, ResourcePool resourcePool) {
+    Pattern zVariablePattern = Pattern.compile("([^{}]*)([{]+[^{}]*[}]+)(.*)", Pattern.DOTALL);

Review comment:
       I fixed. But No difference was found from the execution time of `ZeppCtxtVariableTest`.
   Below is the execution time of 18 tests of `ZeppCtxtVariableTest`. (measured 10 times each)
   statistics | before (ms) | after (ms) 
   -------|--------|-------
   average | 235.6| 234.6
   std. dev. | 12.6 | 26.5




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org