You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/24 16:57:53 UTC
[GitHub] [skywalking-java] dmsolr opened a new pull request #55: add test case plugin on jdk17
dmsolr opened a new pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👇 ====
### Add an agent plugin to support <framework name>
- [ ] Add a test case for the new plugin, refer to [the doc](https://github.com/apache/skywalking-java/blob/main/docs/en/setup/service-agent/java-agent/Plugin-test.md)
- [ ] Add a component id in [the component-libraries.yml](https://github.com/apache/skywalking/blob/master/oap-server/server-starter/src/main/resources/component-libraries.yml)
- [ ] Add a logo in [the UI repo](https://github.com/apache/skywalking-rocketbot-ui/tree/master/src/views/components/topology/assets)
==== 🔌 Remove this line WHEN AND ONLY WHEN you're adding a new plugin, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking-java/blob/main/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [ x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #7942
- [ ] Update the [`CHANGES` log](https://github.com/apache/skywalking-java/blob/main/CHANGES.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744124868
##########
File path: .github/workflows/plugins-test.1.yaml
##########
@@ -81,9 +81,10 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 8
+ distribution: 'temurin'
Review comment:
Here
##########
File path: test/plugin/containers/jvm-container/pom.xml
##########
@@ -32,95 +32,44 @@
<artifactId>jvm-container</artifactId>
<name>SkyWalking JVM Runner Image</name>
- <profiles>
- <profile>
- <id>jdk8</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk8-${project.version}</name>
- <build>
- <from>openjdk:8u102</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>jdk14</id>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk14-${project.version}</name>
- <build>
- <from>openjdk:14-buster</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.33.0</version>
+ <configuration>
+ <images>
+ <image>
+ <name>skywalking/agent-test-jvm:jdk${java_major_version}-${project.version}</name>
+ <build>
+ <from>openjdk:${java_major_version}-buster</from>
Review comment:
Please use the same base images as what we are using in our official Docker images
https://github.com/apache/skywalking-java/blob/02d6b9c2d85da2b1b1ce3e2a8013373e0e371ba1/Makefile#L44-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744127813
##########
File path: test/plugin/containers/jvm-container/pom.xml
##########
@@ -32,95 +32,44 @@
<artifactId>jvm-container</artifactId>
<name>SkyWalking JVM Runner Image</name>
- <profiles>
- <profile>
- <id>jdk8</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk8-${project.version}</name>
- <build>
- <from>openjdk:8u102</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>jdk14</id>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk14-${project.version}</name>
- <build>
- <from>openjdk:14-buster</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.33.0</version>
+ <configuration>
+ <images>
+ <image>
+ <name>skywalking/agent-test-jvm:jdk${java_major_version}-${project.version}</name>
+ <build>
+ <from>openjdk:${java_major_version}-buster</from>
Review comment:
@dmsolr told me there are some error in script in alpine, and our previous testing is on the top of this version due to the limitation of our scripts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#issuecomment-955825265
Please update the document.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744110904
##########
File path: test/plugin/containers/jvm-container/pom.xml
##########
@@ -32,95 +32,44 @@
<artifactId>jvm-container</artifactId>
<name>SkyWalking JVM Runner Image</name>
- <profiles>
- <profile>
- <id>jdk8</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk8-${project.version}</name>
- <build>
- <from>openjdk:8u102</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>jdk14</id>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk14-${project.version}</name>
- <build>
- <from>openjdk:14-buster</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.33.0</version>
+ <configuration>
+ <images>
+ <image>
+ <name>skywalking/agent-test-jvm:jdk${java_major_version}-${project.version}</name>
+ <build>
+ <from>openjdk:${java_major_version}-buster</from>
Review comment:
Same here.
##########
File path: docs/en/setup/service-agent/java-agent/Plugin-test.md
##########
@@ -20,17 +20,18 @@ The test framework provides `JVM-container` and `Tomcat-container` base images i
### JVM-container Image Introduction
-[JVM-container](../../../../../test/plugin/containers/jvm-container) uses `openjdk:8` as the base image. `JVM-container` supports JDK14, which inherits `openjdk:14`.
+[JVM-container](../../../../../test/plugin/containers/jvm-container) uses `openjdk:8-buster` as the base image. `JVM-container` supports JDK14 and JDK17, which inherits `openjdk:14-buster` and `openjdk:17-buster`.
Review comment:
What is buster suffix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744124837
##########
File path: .github/workflows/plugins-test.0.yaml
##########
@@ -90,9 +90,10 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 8
+ distribution: 'temurin'
Review comment:
And here, we only use temurin distribution when using Java 17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng merged pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744127935
##########
File path: test/plugin/containers/jvm-container/pom.xml
##########
@@ -32,95 +32,44 @@
<artifactId>jvm-container</artifactId>
<name>SkyWalking JVM Runner Image</name>
- <profiles>
- <profile>
- <id>jdk8</id>
- <activation>
- <activeByDefault>true</activeByDefault>
- </activation>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk8-${project.version}</name>
- <build>
- <from>openjdk:8u102</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
-
- <profile>
- <id>jdk14</id>
- <build>
- <plugins>
- <plugin>
- <groupId>io.fabric8</groupId>
- <artifactId>docker-maven-plugin</artifactId>
- <version>0.33.0</version>
- <configuration>
- <images>
- <image>
- <name>skywalking/agent-test-jvm:jdk14-${project.version}</name>
- <build>
- <from>openjdk:14-buster</from>
- <workdir>/usr/local/skywalking/scenario</workdir>
- <assembly>
- <mode>dir</mode>
- <targetDir>/usr/local/skywalking</targetDir>
- <descriptor>assembly.xml</descriptor>
- </assembly>
- <runCmds>
- <run>chmod +x /usr/local/skywalking/run.sh</run>
- <run>tar -xvf ../tools/skywalking-mock-collector.tar.gz -C ../tools</run>
- </runCmds>
- <cmd>["/usr/local/skywalking/run.sh"]</cmd>
- </build>
- </image>
- </images>
- </configuration>
- <executions>
- <execution>
- <id>build</id>
- <phase>package</phase>
- <goals>
- <goal>build</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
- </profile>
- </profiles>
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>io.fabric8</groupId>
+ <artifactId>docker-maven-plugin</artifactId>
+ <version>0.33.0</version>
+ <configuration>
+ <images>
+ <image>
+ <name>skywalking/agent-test-jvm:jdk${java_major_version}-${project.version}</name>
+ <build>
+ <from>openjdk:${java_major_version}-buster</from>
Review comment:
I think we were using this. We tried openjdk:alpine here IIRC, the tests would fail
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744127013
##########
File path: .github/workflows/plugins-test.0.yaml
##########
@@ -90,9 +90,10 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 8
+ distribution: 'temurin'
Review comment:
temurin-8 is another distribution of OpenJDK-8, after joining the Eclipse foundation, I think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] wu-sheng commented on pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#issuecomment-955834536
MySQL case fails due to codes runtime exception. It seems having JDK11 in the runtime, which from reviewing codes it should be JDK8. Please recheck.
https://stackoverflow.com/questions/67332909/why-can-java-not-connect-to-mysql-5-7-after-the-latest-jdk-update-and-how-should
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-java] kezhenxu94 commented on a change in pull request #55: add test case plugin on jdk17
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #55:
URL: https://github.com/apache/skywalking-java/pull/55#discussion_r744124704
##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -62,11 +62,13 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 14
+ # temurin does not distribute non-lts version
+ distribution: 'zulu'
Review comment:
Why do you use these distribution instead of those that we are using in our official Docker images?
##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -62,11 +62,13 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 14
+ # temurin does not distribute non-lts version
+ distribution: 'zulu'
Review comment:
Why do you use these distribution instead of those that we are using in our official Docker images?
Please use the same base images as what we are using in our official Docker images
##########
File path: .github/workflows/plugins-jdk14-test.0.yaml
##########
@@ -62,11 +62,13 @@ jobs:
- uses: actions/checkout@v2
with:
submodules: true
- - uses: actions/setup-java@v1
+ - uses: actions/setup-java@v2
with:
- java-version: 14
+ # temurin does not distribute non-lts version
+ distribution: 'zulu'
Review comment:
Why do you use these distribution instead of those that we are using in our official Docker images?
https://github.com/apache/skywalking-java/blob/02d6b9c2d85da2b1b1ce3e2a8013373e0e371ba1/Makefile#L44-L51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org