Re: [PR] allow queries with filtered aggs to match unfiltered projection aggs as long as the filter required columns are present (druid)

["cecemei (via GitHub)" <gi...@apache.org>]

cecemei commented on code in PR #18535:
URL: https://github.com/apache/druid/pull/18535#discussion_r2357215303


##########
processing/src/main/java/org/apache/druid/segment/projections/Projections.java:
##########
@@ -296,6 +292,10 @@ public static ProjectionMatchBuilder matchAggregators(
     }
     boolean allMatch = true;
     for (AggregatorFactory queryAgg : queryCursorBuildSpec.getAggregators()) {
+      AggregatorFactory filterAgg = null;

Review Comment:
   nit: maybe can move `FilteredAggregatorFactory filteredQueryAgg` up here and check null for that instead 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org