You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@isis.apache.org by da...@apache.org on 2019/09/29 14:18:32 UTC

[isis] branch ISIS-2086 updated: ISIS-2086: rework (unused) 'isis.persistor.enforceSafeSemantics' as type-safe config

This is an automated email from the ASF dual-hosted git repository.

danhaywood pushed a commit to branch ISIS-2086
in repository https://gitbox.apache.org/repos/asf/isis.git


The following commit(s) were added to refs/heads/ISIS-2086 by this push:
     new 57d155a  ISIS-2086: rework (unused) 'isis.persistor.enforceSafeSemantics' as type-safe config
57d155a is described below

commit 57d155aadc4c8e8217d25afff1f6a2897e0bd898
Author: danhaywood <da...@haywood-associates.co.uk>
AuthorDate: Sun Sep 29 15:18:18 2019 +0100

    ISIS-2086: rework (unused) 'isis.persistor.enforceSafeSemantics' as type-safe config
---
 .../org/apache/isis/config/IsisConfiguration.java  | 18 ++++++++++
 .../runtime/persistence/PersistenceConstants.java  | 39 ----------------------
 2 files changed, 18 insertions(+), 39 deletions(-)

diff --git a/core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java b/core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
index 2dd989a..62c40a4 100644
--- a/core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
+++ b/core/config/src/main/java/org/apache/isis/config/IsisConfiguration.java
@@ -76,7 +76,25 @@ public class IsisConfiguration {
         @Data
         public static class Datanucleus {
             private String classMetadataLoadedListener = "org.apache.isis.jdo.datanucleus.CreateSchemaObjectFromClassMetadata";
+
+            private final Impl impl = new Impl();
+            @Data
+            public static class Impl {
+
+            }
         }
+        /**
+         * Default is <code>false</code> only for backward compatibility (to avoid lots of breakages in existing code);
+         * in future might change to <code>true</code>.
+         *
+         * <p>
+         *     currently disabled (in ISIS-921); to reinstate in ISIS-922? else delete.
+         * </p>
+         *
+         * @deprecated
+         */
+        @Deprecated
+        private boolean enforceSafeSemantics = false;
     }
     private final Reflector reflector = new Reflector();
     @Data
diff --git a/core/runtime/src/main/java/org/apache/isis/runtime/persistence/PersistenceConstants.java b/core/runtime/src/main/java/org/apache/isis/runtime/persistence/PersistenceConstants.java
deleted file mode 100644
index da233e0..0000000
--- a/core/runtime/src/main/java/org/apache/isis/runtime/persistence/PersistenceConstants.java
+++ /dev/null
@@ -1,39 +0,0 @@
-/*
- *  Licensed to the Apache Software Foundation (ASF) under one
- *  or more contributor license agreements.  See the NOTICE file
- *  distributed with this work for additional information
- *  regarding copyright ownership.  The ASF licenses this file
- *  to you under the Apache License, Version 2.0 (the
- *  "License"); you may not use this file except in compliance
- *  with the License.  You may obtain a copy of the License at
- *
- *        http://www.apache.org/licenses/LICENSE-2.0
- *
- *  Unless required by applicable law or agreed to in writing,
- *  software distributed under the License is distributed on an
- *  "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- *  KIND, either express or implied.  See the License for the
- *  specific language governing permissions and limitations
- *  under the License.
- */
-
-package org.apache.isis.runtime.persistence;
-
-public final class PersistenceConstants {
-
-
-    // disabled in ISIS-921, to reinstate in ISIS-922
-    public static final String ENFORCE_SAFE_SEMANTICS = "isis.persistor.enforceSafeSemantics";
-
-    /**
-     * Default is <code>false</code> only for backward compatibility (to avoid lots of breakages in existing code);
-     * in future might change to <code>true</code>.
-     *
-     * disabled in ISIS-921, to reinstate in ISIS-922
-     */
-    public static final boolean ENFORCE_SAFE_SEMANTICS_DEFAULT = false;
-
-    private PersistenceConstants() {
-    }
-
-}