You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by ra...@apache.org on 2018/09/19 14:59:29 UTC

[cordova-js] branch master updated: Add test labels from #140 that were missed in #172 (#174)

This is an automated email from the ASF dual-hosted git repository.

raphinesse pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/cordova-js.git


The following commit(s) were added to refs/heads/master by this push:
     new a2c78c7  Add test labels from #140 that were missed in #172 (#174)
a2c78c7 is described below

commit a2c78c790e0a79ff974e239ebd8007ebf43a78bb
Author: Raphael von der GrĂ¼n <ra...@gmail.com>
AuthorDate: Wed Sep 19 16:59:21 2018 +0200

    Add test labels from #140 that were missed in #172 (#174)
---
 test/test.argscheck.js | 2 +-
 test/test.base64.js    | 8 ++++----
 test/test.channel.js   | 2 +-
 test/test.utils.js     | 2 +-
 4 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/test/test.argscheck.js b/test/test.argscheck.js
index 6d057c7..09db660 100644
--- a/test/test.argscheck.js
+++ b/test/test.argscheck.js
@@ -73,7 +73,7 @@ describe('argscheck', function () {
         var testFunc = createTestFunc(true);
         expect(function () { testFunc(null, null, null, null, null, new Date()); }).toThrow('Wrong type for parameter "func" of testFunc: Expected Function, but got Date.');
     });
-    it('should not throw when checking is disabled', function () {
+    it('Test#011 : should not throw when checking is disabled', function () {
         var testFunc = createTestFunc(false);
         argscheck.enableChecks = false;
         testFunc();
diff --git a/test/test.base64.js b/test/test.base64.js
index 317fe26..1f33460 100644
--- a/test/test.base64.js
+++ b/test/test.base64.js
@@ -22,7 +22,7 @@
 describe('base64', function () {
     var base64 = require('cordova/base64');
 
-    it('can base64 encode strings correctly', function () {
+    it('Test#001 : can base64 encode strings correctly', function () {
         var arrayBuffer = new ArrayBuffer(6);
         var view = new Uint8Array(arrayBuffer);
         for (var i = 0; i < view.length; i++) {
@@ -36,7 +36,7 @@ describe('base64', function () {
         expect(base64.fromArrayBuffer(arrayBuffer)).toBe('AAECAwQF');
     });
 
-    it('can base64 encode a binary string in an ArrayBuffer', function () {
+    it('Test#002 : can base64 encode a binary string in an ArrayBuffer', function () {
         var arrayBuffer = new ArrayBuffer(256);
         var view = new Uint8Array(arrayBuffer);
         /* eslint-disable no-undef */
@@ -49,7 +49,7 @@ describe('base64', function () {
         expect(base64.fromArrayBuffer(arrayBuffer)).toBe(base64string);
     });
 
-    it('can base64 encode an text string in an ArrayBuffer', function () {
+    it('Test#003 : can base64 encode an text string in an ArrayBuffer', function () {
         var orig = 'Some Awesome Test This Is!';
         var base64string = typeof btoa !== 'undefined' ? btoa(orig) : Buffer.from('Some Awesome Test This Is!', 'binary').toString('base64');
         var arrayBuffer = new ArrayBuffer(orig.length);
@@ -62,7 +62,7 @@ describe('base64', function () {
         expect(base64.fromArrayBuffer(arrayBuffer)).toBe(base64string);
     });
 
-    it('can decode a base64-encoded text string into an ArrayBuffer', function () {
+    it('Test#004 : can decode a base64-encoded text string into an ArrayBuffer', function () {
         var orig = 'Some Awesome Test This Is!';
         var base64string = typeof btoa !== 'undefined' ? btoa(orig) : Buffer.from(orig, 'binary').toString('base64');
         /* eslint-enable no-undef */
diff --git a/test/test.channel.js b/test/test.channel.js
index 09290d8..49de5ee 100644
--- a/test/test.channel.js
+++ b/test/test.channel.js
@@ -336,7 +336,7 @@ describe('channel', function () {
         });
     });
     describe('onHasSubscribersChange', function () {
-        it('should be called only when the first subscriber is added and last subscriber is removed.', function () {
+        it('Test#027 : should be called only when the first subscriber is added and last subscriber is removed.', function () {
             var handler = jasmine.createSpy().andCallFake(function () {
                 if (callCount(handler) === 1) {
                     expect(this.numHandlers).toEqual(1);
diff --git a/test/test.utils.js b/test/test.utils.js
index 1b5e751..68c7ec0 100644
--- a/test/test.utils.js
+++ b/test/test.utils.js
@@ -38,7 +38,7 @@ describe('utils', function () {
     });
 
     describe('utils.arrayRemove', function () {
-        it('should return true when removed.', function () {
+        it('Test#005 : should return true when removed.', function () {
             var a = [1, 2, 3];
             expect(utils.arrayRemove(a, 2)).toBe(true);
             expect(a).toEqual([1, 3]);


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org