You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "melgenek (via GitHub)" <gi...@apache.org> on 2023/02/02 09:45:57 UTC
[GitHub] [arrow-datafusion] melgenek opened a new pull request, #5158: Compare NULL types
melgenek opened a new pull request, #5158:
URL: https://github.com/apache/arrow-datafusion/pull/5158
# Which issue does this PR close?
Closes #4335.
# Rationale for this change
These queries should produce a value instead of an error
```
❯ select null and null;
❯ select null or null;
```
# What changes are included in this PR?
Null comparison coercion and tests.
I made the null logical comparison produce booleans. This is the Postgres does it, and DataFusion seems to be compatible with Postgres.
# Are these changes tested?
Sqllogictests and unit tests
# Are there any user-facing changes?
`null and null` and `null or null` would produce Boolean null value instead of an error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb merged pull request #5158: Compare NULL types
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #5158:
URL: https://github.com/apache/arrow-datafusion/pull/5158
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] ursabot commented on pull request #5158: Compare NULL types
Posted by "ursabot (via GitHub)" <gi...@apache.org>.
ursabot commented on PR #5158:
URL: https://github.com/apache/arrow-datafusion/pull/5158#issuecomment-1414139381
Benchmark runs are scheduled for baseline = e41c4dffa8699165c90dcb5127cd2909869e2f58 and contender = 7d2d51b651d076d720e2879661346babcda9734a. 7d2d51b651d076d720e2879661346babcda9734a is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/c44ac284586948cbac0cddd140b0816a...d9f9534cb55941d2b2c18ee13d7c4f7c/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/e0c8cf78b2d846458363319f96321f32...6d80d974aab44986b7bea20a323ccba3/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/708644587d24415c8bfe0ecf7d9ac792...932aab4c2f6e4fcbb6c7c5bd62fed6fc/)
[Skipped :warning: Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/c8d93bccb943477e997da96b7d7da0ec...2fae27aa4365456bafca3605763bee9b/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] melgenek commented on pull request #5158: Compare NULL types
Posted by "melgenek (via GitHub)" <gi...@apache.org>.
melgenek commented on PR #5158:
URL: https://github.com/apache/arrow-datafusion/pull/5158#issuecomment-1414222523
@alamb
> I double checked postgres
The sqllogictest contains the same test as you performed manually https://github.com/melgenek/arrow-datafusion/blob/f1087f5c042ea093c6fd4d700dcecd8d2da6bf4a/datafusion/core/tests/sqllogictests/test_files/pg_compat/pg_compat_type_coercion.slt#L111-L115. It is just not visible in the git diff, because I added it in [another pr](https://github.com/apache/arrow-datafusion/pull/5148)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-datafusion] alamb commented on a diff in pull request #5158: Compare NULL types
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #5158:
URL: https://github.com/apache/arrow-datafusion/pull/5158#discussion_r1094863478
##########
datafusion/core/tests/sqllogictests/test_files/pg_compat/pg_compat_type_coercion.slt:
##########
@@ -95,20 +95,17 @@ select pg_typeof(false or true), pg_typeof(true or false);
bool bool
-# TODO: run for DataFusion as well after #4335
-onlyif postgres
query ??
select null and null, null or null;
----
NULL NULL
-# TODO: uncomment after #4335
-#onlyif DataFusion
-#query ??
-#select arrow_typeof(null and null), arrow_typeof(null or null);
-#----
-#Boolean Boolean
+onlyif DataFusion
+query ??
+select arrow_typeof(null and null), arrow_typeof(null or null);
Review Comment:
👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org