You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/06/14 16:06:54 UTC

[GitHub] [shardingsphere] strongduanmu opened a new pull request, #18366: Support create index on table(column) statement rewrite when config encrypt

strongduanmu opened a new pull request, #18366:
URL: https://github.com/apache/shardingsphere/pull/18366

   Fixes #18301.
   
   Changes proposed in this pull request:
   - add EncryptCreateIndexTokenGenerator to rewrite `create index on table(column)` statement
   - rename rewrite test case file name
   - add alter index case
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] tuichenchuxin merged pull request #18366: Support create index on table(column) statement rewrite when config encrypt

Posted by GitBox <gi...@apache.org>.
tuichenchuxin merged PR #18366:
URL: https://github.com/apache/shardingsphere/pull/18366


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] codecov-commenter commented on pull request #18366: Support create index on table(column) statement rewrite when config encrypt

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18366:
URL: https://github.com/apache/shardingsphere/pull/18366#issuecomment-1155465076

   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18366?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#18366](https://codecov.io/gh/apache/shardingsphere/pull/18366?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (261a64a) into [master](https://codecov.io/gh/apache/shardingsphere/commit/a72e919961aba51e73d95bf5dd5dcb57df4d5514?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a72e919) will **decrease** coverage by `0.02%`.
   > The diff coverage is `8.00%`.
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18366      +/-   ##
   ============================================
   - Coverage     59.16%   59.13%   -0.03%     
   - Complexity     2193     2194       +1     
   ============================================
     Files          3736     3737       +1     
     Lines         54757    54782      +25     
     Branches       9308     9311       +3     
   ============================================
   - Hits          32398    32397       -1     
   - Misses        19603    19628      +25     
   - Partials       2756     2757       +1     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/18366?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...en/generator/EncryptCreateIndexTokenGenerator.java](https://codecov.io/gh/apache/shardingsphere/pull/18366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9nZW5lcmF0b3IvRW5jcnlwdENyZWF0ZUluZGV4VG9rZW5HZW5lcmF0b3IuamF2YQ==) | `4.16% <4.16%> (ø)` | |
   | [...ypt/rewrite/token/EncryptTokenGenerateBuilder.java](https://codecov.io/gh/apache/shardingsphere/pull/18366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtZmVhdHVyZXMvc2hhcmRpbmdzcGhlcmUtZW5jcnlwdC9zaGFyZGluZ3NwaGVyZS1lbmNyeXB0LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VuY3J5cHQvcmV3cml0ZS90b2tlbi9FbmNyeXB0VG9rZW5HZW5lcmF0ZUJ1aWxkZXIuamF2YQ==) | `80.76% <100.00%> (+0.76%)` | :arrow_up: |
   | [...d/text/distsql/ral/common/hint/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/18366/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtcHJveHkvc2hhcmRpbmdzcGhlcmUtcHJveHktYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC90ZXh0L2Rpc3RzcWwvcmFsL2NvbW1vbi9oaW50L0hpbnRTb3VyY2VUeXBlLmphdmE=) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18366?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/18366?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [a72e919...261a64a](https://codecov.io/gh/apache/shardingsphere/pull/18366?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org