You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tajo.apache.org by ji...@apache.org on 2013/12/28 07:36:26 UTC

[29/50] [abbrv] TAJO-182: Correct NULL value handling of primitive operators. (hyunsik)

http://git-wip-us.apache.org/repos/asf/incubator-tajo/blob/e8c5c277/tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
----------------------------------------------------------------------
diff --git a/tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java b/tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
index fbcc9a0..f4172dc 100644
--- a/tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
+++ b/tajo-core/tajo-core-backend/src/test/java/org/apache/tajo/engine/query/TestJoinQuery.java
@@ -114,7 +114,7 @@ public class TestJoinQuery {
       }
 
       for (int i = 0; i < 3; i++) {
-        res.next();
+        assertTrue(res.next());
         Object [] resultTuple = resultSet.get(res.getFloat("s_acctbal"));
         assertEquals(resultTuple[0], res.getFloat("s_acctbal"));
         assertEquals(resultTuple[1], res.getString("s_name"));
@@ -157,7 +157,8 @@ public class TestJoinQuery {
       result.put(3, 3);
       result.put(4, 0);
       result.put(5, 0);
-      while(res.next()) {
+      for (int i = 0; i < result.size(); i++) {
+        assertTrue(res.next());
         assertTrue(result.get(res.getInt(1)) == res.getInt(2));
       }
     } finally {
@@ -168,7 +169,7 @@ public class TestJoinQuery {
   @Test
   public final void testFullOuterJoin1() throws Exception {
     ResultSet res = tpch.execute(
-        "select c_custkey, orders.o_orderkey, from orders full outer join customer on c_custkey = o_orderkey;");
+        "select c_custkey, orders.o_orderkey from orders full outer join customer on c_custkey = o_orderkey;");
     try {
       Map<Integer, Integer> result = Maps.newHashMap();
       result.put(1, 1);
@@ -176,7 +177,8 @@ public class TestJoinQuery {
       result.put(3, 3);
       result.put(4, 0);
       result.put(5, 0);
-      while(res.next()) {
+      for (int i = 0; i < result.size(); i++) {
+        assertTrue(res.next());
         assertTrue(result.get(res.getInt(1)) == res.getInt(2));
       }
     } finally {
@@ -186,7 +188,9 @@ public class TestJoinQuery {
 
   @Test
   public void testJoinRefEval() throws Exception {
-    ResultSet res = tpch.execute("select r_regionkey, n_regionkey, (r_regionkey + n_regionkey) as plus from region, nation where r_regionkey = n_regionkey");
+    ResultSet res = tpch.execute(
+        "select r_regionkey, n_regionkey, (r_regionkey + n_regionkey) as plus from region, nation " +
+            "where r_regionkey = n_regionkey");
     try {
       int r, n;
       while(res.next()) {