[GitHub] [echarts] MasterOdin commented on a diff in pull request #17464: fix(type): add alignWithLabel and interval props to AxisTick

[GitBox <gi...@apache.org>]

MasterOdin commented on code in PR #17464:
URL: https://github.com/apache/echarts/pull/17464#discussion_r936173003


##########
src/coord/axisCommonTypes.ts:
##########
@@ -179,6 +179,8 @@ interface AxisLineOption {
 
 interface AxisTickOption {
     show?: boolean | 'auto',
+    alignWithLabel?: boolean,
+    interval?: 'auto' | number | ((index:number, value: string) => boolean),

Review Comment:
   Ah, okay. We had been using `XAxisOption` and I had considered `SingleAxisComponentOption` as we had logic to toggle between `value` and `category` depending on incoming data and that had felt appropriate. I suppose we could get by by doing `CategoryAxisBaseOptions & ValueAxisBaseOption` (as opposed to doing the intersection that `XAxisOption` is doing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@echarts.apache.org
For additional commands, e-mail: commits-help@echarts.apache.org