You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ta...@apache.org on 2017/01/06 21:57:38 UTC
[1/3] qpid-jms git commit: QPIDJMS-232 Fix a few warnings
Repository: qpid-jms
Updated Branches:
refs/heads/master b2f137b09 -> 28662b35b
QPIDJMS-232 Fix a few warnings
Add missing javadoc tag and remove throw declaration that is no longer
valid.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/c5e2b4f1
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/c5e2b4f1
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/c5e2b4f1
Branch: refs/heads/master
Commit: c5e2b4f16a22bc8b2b8b132aa9dc531ac3797a59
Parents: b2f137b
Author: Timothy Bish <ta...@gmail.com>
Authored: Fri Jan 6 16:55:32 2017 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Fri Jan 6 16:55:32 2017 -0500
----------------------------------------------------------------------
.../org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/c5e2b4f1/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java
index 96168f2..9ee41e5 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/provider/amqp/AmqpSaslAuthenticator.java
@@ -44,6 +44,8 @@ public class AmqpSaslAuthenticator {
/**
* Create the authenticator and initialize it.
*
+ * @param request
+ * The initial request that is awaiting the result of the authentication process.
* @param sasl
* The Proton SASL entry point this class will use to manage the authentication.
* @param info
@@ -83,7 +85,7 @@ public class AmqpSaslAuthenticator {
*
* @return true if the authentication process completed.
*/
- public boolean authenticate() throws JMSSecurityException {
+ public boolean authenticate() {
try {
switch (sasl.getState()) {
case PN_SASL_IDLE:
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[2/3] qpid-jms git commit: NO-JIRA Remove warnings suppressors that
are no longer needed.
Posted by ta...@apache.org.
NO-JIRA Remove warnings suppressors that are no longer needed.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/8ab6ad7b
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/8ab6ad7b
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/8ab6ad7b
Branch: refs/heads/master
Commit: 8ab6ad7b018129cda8b7429d5a0f064408fbb6bc
Parents: c5e2b4f
Author: Timothy Bish <ta...@gmail.com>
Authored: Fri Jan 6 16:56:42 2017 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Fri Jan 6 16:56:42 2017 -0500
----------------------------------------------------------------------
.../java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java | 1 -
.../src/main/java/org/apache/qpid/jms/jndi/LazyCreateContext.java | 1 -
2 files changed, 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/8ab6ad7b/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java
index f70017c..5588095 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/JmsInitialContextFactory.java
@@ -54,7 +54,6 @@ public class JmsInitialContextFactory implements InitialContextFactory {
static final String DYNAMIC_QUEUES = "dynamicQueues";
static final String DYNAMIC_TOPICS = "dynamicTopics";
- @SuppressWarnings("unchecked")
@Override
public Context getInitialContext(Hashtable<?, ?> environment) throws NamingException {
// Copy the environment to ensure we don't modify/reference it, it belongs to the caller.
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/8ab6ad7b/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/LazyCreateContext.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/LazyCreateContext.java b/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/LazyCreateContext.java
index 7caf8ec..68d954a 100644
--- a/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/LazyCreateContext.java
+++ b/qpid-jms-client/src/main/java/org/apache/qpid/jms/jndi/LazyCreateContext.java
@@ -24,7 +24,6 @@ import javax.naming.NamingException;
*
* @since 1.0
*/
-@SuppressWarnings("unchecked")
public abstract class LazyCreateContext extends ReadOnlyContext {
private static final long serialVersionUID = 5131341840091473967L;
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org
[3/3] qpid-jms git commit: NO-JIRA Add missing JavaDoc tags to fix
warnings from code inspector.
Posted by ta...@apache.org.
NO-JIRA Add missing JavaDoc tags to fix warnings from code inspector.
Project: http://git-wip-us.apache.org/repos/asf/qpid-jms/repo
Commit: http://git-wip-us.apache.org/repos/asf/qpid-jms/commit/28662b35
Tree: http://git-wip-us.apache.org/repos/asf/qpid-jms/tree/28662b35
Diff: http://git-wip-us.apache.org/repos/asf/qpid-jms/diff/28662b35
Branch: refs/heads/master
Commit: 28662b35b6ccb8ac562c9e2c2261ef859b6b2967
Parents: 8ab6ad7
Author: Timothy Bish <ta...@gmail.com>
Authored: Fri Jan 6 16:57:24 2017 -0500
Committer: Timothy Bish <ta...@gmail.com>
Committed: Fri Jan 6 16:57:24 2017 -0500
----------------------------------------------------------------------
.../org/apache/qpid/jms/integration/SslIntegrationTest.java | 6 +++++-
.../qpid/jms/integration/SubscriptionsIntegrationTest.java | 8 ++++++++
2 files changed, 13 insertions(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/28662b35/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SslIntegrationTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SslIntegrationTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SslIntegrationTest.java
index 5289a48..682c983 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SslIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SslIntegrationTest.java
@@ -21,9 +21,9 @@
package org.apache.qpid.jms.integration;
import static org.junit.Assert.assertEquals;
-import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertNotEquals;
import static org.junit.Assert.assertNotNull;
+import static org.junit.Assert.assertNull;
import static org.junit.Assert.assertTrue;
import static org.junit.Assert.fail;
@@ -231,6 +231,8 @@ public class SslIntegrationTest extends QpidJmsTestCase {
* Checks that configuring different SSLContext instances using different client key
* stores via {@link JmsConnectionFactory#setSslContext(SSLContext)} results
* in different certificates being observed server side following handshake.
+ *
+ * @throws Exception if an unexpected error is encountered
*/
@Test(timeout = 20000)
public void testCreateConnectionWithSslContextOverride() throws Exception {
@@ -294,6 +296,8 @@ public class SslIntegrationTest extends QpidJmsTestCase {
* {@link JmsConnectionFactory#setSslContext(SSLContext)} overrides URI config
* for store location etc, resulting in a different certificate being observed
* server side following handshake.
+ *
+ * @throws Exception if an unexpected error is encountered
*/
@Test(timeout = 20000)
public void testCreateConnectionWithSslContextOverrideAndURIConfig() throws Exception {
http://git-wip-us.apache.org/repos/asf/qpid-jms/blob/28662b35/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SubscriptionsIntegrationTest.java
----------------------------------------------------------------------
diff --git a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SubscriptionsIntegrationTest.java b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SubscriptionsIntegrationTest.java
index f1bd390..e9739ed 100644
--- a/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SubscriptionsIntegrationTest.java
+++ b/qpid-jms-client/src/test/java/org/apache/qpid/jms/integration/SubscriptionsIntegrationTest.java
@@ -1105,6 +1105,8 @@ public class SubscriptionsIntegrationTest extends QpidJmsTestCase {
/**
* Verifies that subscriber cleanup occurs when the subscriber is remotely closed (after creation).
+ *
+ * @throws Exception if an unexpected error is encountered
*/
@Test(timeout = 20000)
public void testRemotelyDetachLinkWithDurableSharedConsumer() throws Exception {
@@ -1357,6 +1359,8 @@ public class SubscriptionsIntegrationTest extends QpidJmsTestCase {
/**
* Verifies that subscriber cleanup occurs when the session it is on is remotely closed.
+ *
+ * @throws Exception if an unexpected error is encountered
*/
@Test(timeout = 20000)
public void testRemotelyEndSessionWithDurableSharedConsumer() throws Exception {
@@ -1439,6 +1443,8 @@ public class SubscriptionsIntegrationTest extends QpidJmsTestCase {
/**
* Verifies that subscriber cleanup occurs when the session it is on is locally closed.
+ *
+ * @throws Exception if an unexpected error is encountered
*/
@Test(timeout = 20000)
public void testLocallyEndSessionWithSharedConsumer() throws Exception {
@@ -1521,6 +1527,8 @@ public class SubscriptionsIntegrationTest extends QpidJmsTestCase {
* Verifies that subscription name passed is not allowed to have the subscription name
* delimiter used in the receiver link naming to separate the subscription name from
* a suffix used to ensure unique link names are used on a connection.
+ *
+ * @throws Exception if an unexpected error is encountered
*/
@Test(timeout = 20000)
public void testSubscriptionNameNotAllowedToHaveNameSeparator() throws Exception {
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@qpid.apache.org
For additional commands, e-mail: commits-help@qpid.apache.org