You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2017/09/19 20:42:26 UTC
Review Request 62418: Removed unneeded configure step in mesos-tidy
Docker image.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62418/
-----------------------------------------------------------
Review request for mesos and Michael Park.
Repository: mesos
Description
-------
The mesos-tidy Docker image uses the cmake build to prepare Mesos for
linting. The cmake build does not require running of 'bootstrap'.
Diffs
-----
support/mesos-tidy/entrypoint.sh 68026f4a00abbca7fc80688b9d16718440596632
Diff: https://reviews.apache.org/r/62418/diff/1/
Testing
-------
Ran the built image with a modified `support/mesos-tidy.sh` that does not force-download the image.
Thanks,
Benjamin Bannier
Re: Review Request 62418: Removed unneeded configure step in
mesos-tidy Docker image.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62418/#review185838
-----------------------------------------------------------
Patch looks great!
Reviews applied: [62417, 62418]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Sept. 19, 2017, 8:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62418/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 8:42 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mesos-tidy Docker image uses the cmake build to prepare Mesos for
> linting. The cmake build does not require running of 'bootstrap'.
>
>
> Diffs
> -----
>
> support/mesos-tidy/entrypoint.sh 68026f4a00abbca7fc80688b9d16718440596632
>
>
> Diff: https://reviews.apache.org/r/62418/diff/1/
>
>
> Testing
> -------
>
> Ran the built image with a modified `support/mesos-tidy.sh` that does not force-download the image.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62418: Removed unneeded configure step in
mesos-tidy Docker image.
Posted by Michael Park <mp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62418/#review187276
-----------------------------------------------------------
Ship it!
Ship It!
- Michael Park
On Sept. 19, 2017, 1:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62418/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 1:42 p.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mesos-tidy Docker image uses the cmake build to prepare Mesos for
> linting. The cmake build does not require running of 'bootstrap'.
>
>
> Diffs
> -----
>
> support/mesos-tidy/entrypoint.sh 68026f4a00abbca7fc80688b9d16718440596632
>
>
> Diff: https://reviews.apache.org/r/62418/diff/1/
>
>
> Testing
> -------
>
> Ran the built image with a modified `support/mesos-tidy.sh` that does not force-download the image.
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 62418: Removed unneeded configure step in
mesos-tidy Docker image.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62418/#review185765
-----------------------------------------------------------
PASS: Mesos patch 62418 was successfully built and tested.
Reviews applied: `['62417', '62418']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/62418
- Mesos Reviewbot Windows
On Sept. 20, 2017, 4:42 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62418/
> -----------------------------------------------------------
>
> (Updated Sept. 20, 2017, 4:42 a.m.)
>
>
> Review request for mesos and Michael Park.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The mesos-tidy Docker image uses the cmake build to prepare Mesos for
> linting. The cmake build does not require running of 'bootstrap'.
>
>
> Diffs
> -----
>
> support/mesos-tidy/entrypoint.sh 68026f4a00abbca7fc80688b9d16718440596632
>
>
> Diff: https://reviews.apache.org/r/62418/diff/1/
>
>
> Testing
> -------
>
> Ran the built image with a modified `support/mesos-tidy.sh` that does not force-download the image.
>
>
> Thanks,
>
> Benjamin Bannier
>
>