You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/06/11 16:28:27 UTC

[GitHub] [geode] jdeppe-pivotal opened a new pull request #5240: GEODE-8242: Add HSTRLEN redis command

jdeppe-pivotal opened a new pull request #5240:
URL: https://github.com/apache/geode/pull/5240


   - Also define PUBSUB as an unimplemented command
   
   Authored-by: Jens Deppe <jd...@vmware.com>
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build issues and
   submit an update to your PR as soon as possible. If you need help, please send an
   email to dev@geode.apache.org.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5240: GEODE-8242: Add HSTRLEN redis command

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5240:
URL: https://github.com/apache/geode/pull/5240#discussion_r440367035



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       We can do something like `jedis.sendCommand(Command.STRLEN, "foo", "bar", ...)` but we don't have explicit tests for command input lengths. They are tested implicitly through the parameter requirements defined against each command in `RedisCommandType`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal commented on a change in pull request #5240: GEODE-8242: Add HSTRLEN redis command

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal commented on a change in pull request #5240:
URL: https://github.com/apache/geode/pull/5240#discussion_r440367035



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       We can do something like `jedis.sendCommand(Command.STRLEN, "foo", "bar", ...)` but we don't have explicit tests for command input lengths. The are tested implicitly through the parameter requirements defined against each command in `RedisCommandType`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] dschneider-pivotal commented on a change in pull request #5240: GEODE-8242: Add HSTRLEN redis command

Posted by GitBox <gi...@apache.org>.
dschneider-pivotal commented on a change in pull request #5240:
URL: https://github.com/apache/geode/pull/5240#discussion_r438972373



##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       do a hstrlen on some other existing type (like a string or set) and confirm you get the expected error

##########
File path: geode-redis/src/integrationTest/java/org/apache/geode/redis/HashesIntegrationTest.java
##########
@@ -150,6 +150,15 @@ public void testHDelDeletesKeyWhenHashIsEmpty() {
     assertThat(jedis.exists("farm")).isFalse();
   }
 
+  @Test
+  public void testHStrLen() {
+    jedis.hset("farm", "chicken", "little");
+
+    assertThat(jedis.hstrlen("farm", "chicken")).isEqualTo("little".length());
+    assertThat(jedis.hstrlen("farm", "unknown-field")).isEqualTo(0);
+    assertThat(jedis.hstrlen("unknown-key", "unknown-field")).isEqualTo(0);
+  }

Review comment:
       do we have a way of testing the wrong number of arguments to a command? Will any of our redis clients even let that happen?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [geode] jdeppe-pivotal merged pull request #5240: GEODE-8242: Add HSTRLEN redis command

Posted by GitBox <gi...@apache.org>.
jdeppe-pivotal merged pull request #5240:
URL: https://github.com/apache/geode/pull/5240


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org