[GitHub] [commons-bcel] kriegaex commented on pull request #139: Improve condy (constant dynamic) support

[GitBox <gi...@apache.org>]

kriegaex commented on PR #139:
URL: https://github.com/apache/commons-bcel/pull/139#issuecomment-1214368007

   So, instead of being happy that someone provides a PR at all after having begged the contributors for a bugfix, and writing a test by yourself, now the PR I was asked for before is not good enough still, and I should provide a test, too? That is quite an interesting experience with this project. What exactly do maintainers do around here? Simply wait for users to do everything? Actually, I do have a test, but it requires JaCoCo in my Maven project. I checked whether you have a Maven Invoker test suite, but you do not. So there is no easy way to provide a test without digging into BCEL's intestines and writing a separate test, similar to the ones you already have with extra precompiled class files that can be processed by BCEL. I do not have the cycles for that. Actually, I only wanted to fix a problem in AspectJ, asking the BCEL team for help. I got none, so I had to fix it myself in AspectJ. I was even nice enough to provide a bugfix for the upstream project, and now that is not 
 good enough. Uh-huh.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@commons.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org