You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/11/25 16:38:52 UTC
[kudu-CR] [thirdparty] Upgrade Protobuf to 3.14.0
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/16784
Change subject: [thirdparty] Upgrade Protobuf to 3.14.0
......................................................................
[thirdparty] Upgrade Protobuf to 3.14.0
This patch upgrades Protobuf from 3.12.3 to 3.14.0.
Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
---
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/84/16784/1
--
To view, visit http://gerrit.cloudera.org:8080/16784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
Gerrit-Change-Number: 16784
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR] [thirdparty] Upgrade Protobuf to 3.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16784 )
Change subject: [thirdparty] Upgrade Protobuf to 3.14.0
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG@7
PS1, Line 7: Upgrade Protobuf
> BTW, do you plan to update protobuf version used in Java part of the projec
Yeah, I will bump the Java versions in bulk at some point per the usual "[Java] Upgrade Dependencies" commit.
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG@9
PS1, Line 9: This patch upgrades Protobuf from 3.12.3 to 3.14.0
> Does it make sense to add more colors about the motivation for this version
I am hopeful this bump will fix the UBSAN issue I was seeing in the C++17 patch, but even if it doesn't we can/should merge it. For that reason, I left it out of this message.
--
To view, visit http://gerrit.cloudera.org:8080/16784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
Gerrit-Change-Number: 16784
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Nov 2020 17:43:34 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade Protobuf to 3.14.0
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/16784 )
Change subject: [thirdparty] Upgrade Protobuf to 3.14.0
......................................................................
[thirdparty] Upgrade Protobuf to 3.14.0
This patch upgrades Protobuf from 3.12.3 to 3.14.0.
Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
Reviewed-on: http://gerrit.cloudera.org:8080/16784
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Kudu Jenkins
---
M thirdparty/download-thirdparty.sh
M thirdparty/vars.sh
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/16784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
Gerrit-Change-Number: 16784
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [thirdparty] Upgrade Protobuf to 3.14.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16784 )
Change subject: [thirdparty] Upgrade Protobuf to 3.14.0
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG@9
PS1, Line 9: This patch upgrades Protobuf from 3.12.3 to 3.14.0
Does it make sense to add more colors about the motivation for this version bump? Was it something special like removal of the inlined string support, UBSAN fixes?
--
To view, visit http://gerrit.cloudera.org:8080/16784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
Gerrit-Change-Number: 16784
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Nov 2020 17:09:01 +0000
Gerrit-HasComments: Yes
[kudu-CR] [thirdparty] Upgrade Protobuf to 3.14.0
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/16784 )
Change subject: [thirdparty] Upgrade Protobuf to 3.14.0
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/16784/1//COMMIT_MSG@7
PS1, Line 7: Upgrade Protobuf
BTW, do you plan to update protobuf version used in Java part of the project in a separate changelist?
--
To view, visit http://gerrit.cloudera.org:8080/16784
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I46617b4c55fc61b28b2837f7a0f04ba9061038ae
Gerrit-Change-Number: 16784
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 25 Nov 2020 17:12:58 +0000
Gerrit-HasComments: Yes