You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/29 15:51:35 UTC

[GitHub] [pulsar] futeng opened a new pull request, #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

futeng opened a new pull request, #16290:
URL: https://github.com/apache/pulsar/pull/16290

   ### Motivation
   
   Remove "not", because configuring the value for the parameter brokerDeleteInactiveTopicsMaxInactiveDurationSeconds will allow the deletion to take effect, not the other way around.
   
   ### Modifications
   
   Simply remove the not from all relevant Java files and Markdown documents
   
   
   ### Documentation
    
   - [x] `doc` 
   
   - [x] `doc-complete`
   
   (I did keyword searches and substitutions, but wasn't sure if I missed anything.)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170167119

   @futeng Please select only one documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] horizonzy commented on a diff in pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
horizonzy commented on code in PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#discussion_r910545812


##########
conf/broker.conf:
##########
@@ -188,7 +188,7 @@ brokerDeleteInactiveTopicsMode=delete_when_no_subscriptions
 brokerDeleteInactivePartitionedTopicMetadataEnabled=false
 
 # Max duration of topic inactivity in seconds, default is not present
-# If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used

Review Comment:
   https://github.com/apache/pulsar/blob/f230d15ffcd5f74cca13bd23b35ace784d6f8ce6/pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java#L2834-L2840



##########
deployment/terraform-ansible/templates/broker.conf:
##########
@@ -133,7 +133,7 @@ brokerDeleteInactiveTopicsFrequencySeconds=60
 brokerDeleteInactiveTopicsMode=delete_when_no_subscriptions
 
 # Max duration of topic inactivity in seconds, default is not present
-# If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used
+# If present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used

Review Comment:
   Should not change it



##########
conf/broker.conf:
##########
@@ -188,7 +188,7 @@ brokerDeleteInactiveTopicsMode=delete_when_no_subscriptions
 brokerDeleteInactivePartitionedTopicMetadataEnabled=false
 
 # Max duration of topic inactivity in seconds, default is not present
-# If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used

Review Comment:
   Should not change it



##########
pulsar-broker-common/src/main/java/org/apache/pulsar/broker/ServiceConfiguration.java:
##########
@@ -576,7 +576,7 @@ public class ServiceConfiguration implements PulsarConfiguration {
     @FieldContext(
         category = CATEGORY_POLICIES,
         doc = "Max duration of topic inactivity in seconds, default is not present\n"
-        + "If not present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used\n"
+        + "If present, 'brokerDeleteInactiveTopicsFrequencySeconds' will be used\n"

Review Comment:
   Should not change it



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] futeng closed pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
futeng closed pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds
URL: https://github.com/apache/pulsar/pull/16290


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170424026

   @futeng Please select only one documentation label for your PR.
   Instructions see [Pulsar Documentation Label Guide](https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170655975

   @futeng thank you!
   1. For each PR, only choose one doc label. Label guideline: https://docs.google.com/document/d/1Qw7LHQdXWBW9t2-r-A7QdFDBwmZh6ytB4guwMoXHqc0/edit#bookmark=id.idby085lkv0t
   2. Please @ me in a comment if you need my review, or else I might miss it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170702652

   @futeng no worries. Welcome more contributions and discussions! 👏


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Anonymitaet commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170656223

   @horizonzy 
   could you please review this PR from the technical perspective? Thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] futeng commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
futeng commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170687895

   @horizonzy @Anonymitaet 
   Sorry, I confused the parameters of the comment. I think the original comment is correct and needs no modification.
   Sorry for wasting your time. I'll close this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] horizonzy commented on pull request #16290: [fix][doc] Modify comments and doc for brokerDeleteInactiveTopicsMaxInactiveDurationSeconds

Posted by GitBox <gi...@apache.org>.
horizonzy commented on PR #16290:
URL: https://github.com/apache/pulsar/pull/16290#issuecomment-1170674487

   From source code, the doc is correct. Why do you think the doc is not match the behavior, give me more context.
   @futeng 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org