[GitHub] [avro] thiru-mg commented on a change in pull request #1168: AVRO-3051: Modernized Avro data parser

[GitBox <gi...@apache.org>]

thiru-mg commented on a change in pull request #1168:
URL: https://github.com/apache/avro/pull/1168#discussion_r605348072



##########
File path: lang/c++/impl/parsing/JsonCodec.cc
##########
@@ -470,30 +466,30 @@ class JsonEncoder : public Encoder {
     JsonHandler<F> handler_;
     P parser_;
 
-    void init(OutputStream &os);
-    void flush();
-    int64_t byteCount() const;
-    void encodeNull();
-    void encodeBool(bool b);
-    void encodeInt(int32_t i);
-    void encodeLong(int64_t l);
-    void encodeFloat(float f);
-    void encodeDouble(double d);
-    void encodeString(const std::string &s);
-    void encodeBytes(const uint8_t *bytes, size_t len);
-    void encodeFixed(const uint8_t *bytes, size_t len);
-    void encodeEnum(size_t e);
-    void arrayStart();
-    void arrayEnd();
-    void mapStart();
-    void mapEnd();
-    void setItemCount(size_t count);
-    void startItem();
-    void encodeUnionIndex(size_t e);
+    void init(OutputStream &os) override;

Review comment:
       Good point. Took care of this and similar uses throughout.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org