[GitHub] [superset] hughhhh commented on a diff in pull request #24248: fix: save columns reference from sqllab save datasets flow

["hughhhh (via GitHub)" <gi...@apache.org>]

hughhhh commented on code in PR #24248:
URL: https://github.com/apache/superset/pull/24248#discussion_r1212346847


##########
superset/queries/dao.py:
##########
@@ -59,6 +59,8 @@ def update_saved_query_exec_info(query_id: int) -> None:
     def save_metadata(query: Query, payload: Dict[str, Any]) -> None:
         # pull relevant data from payload and store in extra_json
         columns = payload.get("columns", {})
+        for col in columns:
+            col["column_name"] = col.pop("name")

Review Comment:
   from the query execution the dict comes back `column[name]`, and decided to update the naming here before returning it to the client



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org